diff options
| author | Vijay Hiremath <vijay.p.hiremath@intel.com> | 2018-04-03 05:44:52 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-04-03 18:47:12 -0700 |
| commit | a9c7d6b0d73eaf0c48438124b40fc054183701aa (patch) | |
| tree | f921024e21f5e6efd707f0b49a8ad75c7a3bc0ee /common/chipset.c | |
| parent | 228dc8d1193d2b4c26f60a9da779803bd41fe172 (diff) | |
| download | chrome-ec-a9c7d6b0d73eaf0c48438124b40fc054183701aa.tar.gz | |
Code cleanup: Remove cold reset logic
Majority of the chipsets do not have a dedicated GPIO to trigger
AP cold reset. Current code either ignores cold reset or does a warm
reset instead or have a work around to put AP in S5 and then bring
back to S0. In order to avoid the confusion, removed the cold reset
logic and only apreset is used hence forth.
BUG=b:72426192
BRANCH=none
TEST=make buildall -j
Manually tested on GLKRVP, apreset EC command can reset AP.
Change-Id: Ie32d34f2f327ff1b61b32a4d874250dce024cf35
Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/991052
Commit-Ready: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Tested-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'common/chipset.c')
| -rw-r--r-- | common/chipset.c | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/common/chipset.c b/common/chipset.c index 1d236fdc14..7a2101624a 100644 --- a/common/chipset.c +++ b/common/chipset.c @@ -20,20 +20,13 @@ #ifdef CONFIG_CMD_POWER_AP static int command_apreset(int argc, char **argv) { - int is_cold = 1; - - if (argc > 1 && !strcasecmp(argv[1], "cold")) - is_cold = 1; - else if (argc > 1 && !strcasecmp(argv[1], "warm")) - is_cold = 0; - /* Force the chipset to reset */ - ccprintf("Issuing AP %s reset...\n", is_cold ? "cold" : "warm"); - chipset_reset(is_cold); + ccprintf("Issuing AP reset...\n"); + chipset_reset(); return EC_SUCCESS; } DECLARE_CONSOLE_COMMAND(apreset, command_apreset, - "[warm | cold]", + NULL, "Issue AP reset"); static int command_apshutdown(int argc, char **argv) |