diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2016-08-23 15:14:56 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-08-24 17:41:12 -0700 |
| commit | 3071b82b5847396136b19acd8c2aa3f4e8f6cd42 (patch) | |
| tree | 9fdb33b87dd7ffef86a4057977cb74889f4fe4ec /common/console.c | |
| parent | 68eb480a882627b5477c39eddde95656dd568758 (diff) | |
| download | chrome-ec-3071b82b5847396136b19acd8c2aa3f4e8f6cd42.tar.gz | |
Remove unused CONFIG_CONSOLE_RESTRICTED_INPUT option
Nothing has used this config option since Spring and Skate, back
in early 2014. There's nothing in ToT that uses it at all. I want
to add something similar for other purposes, and having two
similar-sounding options will just cause confusion.
NOTE: Although the comments in include/system.h said that the two
functions
system_get_console_force_enabled()
system_set_console_force_enabled()
were only useful when CONFIG_CONSOLE_RESTRICTED_INPUT is defined,
they were being used in chip/stm32/system.c. But since the
bkpdata registers are only accessible to the EC, there was no way
to initialize or modify the one relevant bit that those functions
cared about, so they almost certainly had no effect.
BUG=chrome-os-partner:55322
BRANCH=none
TEST=make buildall
Change-Id: Id41541193d4559f5c507bdd0268b049166af4497
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374525
Diffstat (limited to 'common/console.c')
| -rw-r--r-- | common/console.c | 30 |
1 files changed, 0 insertions, 30 deletions
diff --git a/common/console.c b/common/console.c index c451de041f..e64d07f8d7 100644 --- a/common/console.c +++ b/common/console.c @@ -646,15 +646,6 @@ void console_has_input(void) void console_task(void) { -#ifdef CONFIG_CONSOLE_RESTRICTED_INPUT - /* the console is not available due to security restrictions */ - if (system_is_locked() && !system_get_console_force_enabled()) { - ccprintf("Console is DISABLED (WP is ON).\n"); - while (1) - task_wait_event(-1); - } -#endif - console_init(); while (1) { @@ -741,27 +732,6 @@ DECLARE_CONSOLE_COMMAND(help, command_help, "[ list | <name> ]", "Print command help"); -#ifdef CONFIG_CONSOLE_RESTRICTED_INPUT -static int command_force_enabled(int argc, char **argv) -{ - int val; - - if (argc < 2) - return EC_ERROR_PARAM_COUNT; - - if (!parse_bool(argv[1], &val)) - return EC_ERROR_PARAM1; - - system_set_console_force_enabled(val); - ccprintf("Console force enabled = %s\n", val ? "on" : "off"); - - return EC_SUCCESS; -} -DECLARE_CONSOLE_COMMAND(forceen, command_force_enabled, - "<on | off>", - "Force enable console"); -#endif - #ifdef CONFIG_CONSOLE_HISTORY static int command_history(int argc, char **argv) { |