diff options
| author | Vic Yang <victoryang@chromium.org> | 2014-05-19 15:03:27 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-05-21 20:32:17 +0000 |
| commit | ffac23c0ea1bd4ff4568f5bd709a98f912b833a7 (patch) | |
| tree | 362dd0ba205731aa07be97dd35b44b237799b23b /common/extpower_falco.c | |
| parent | 478361de694b1fb45abf3c38dafbbf7fd1aa5f71 (diff) | |
| download | chrome-ec-ffac23c0ea1bd4ff4568f5bd709a98f912b833a7.tar.gz | |
Add cprints() and ccprints()
Our code base contains a lot of debug messages in this pattern:
CPRINTF("[%T xxx]\n") or ccprintf("[%T xxx]\n")
The strings are taking up spaces in the EC binaries, so let's refactor
this by adding cprints() and ccprints().
cprints() is just like cprintf(), except that it adds the brackets
and the timestamp. ccprints() is equivalent to cprints(CC_CONSOLE, ...)
This saves us hundreds of bytes in EC binaries.
BUG=chromium:374575
TEST=Build and check flash size
BRANCH=None
Change-Id: Ifafe8dc1b80e698b28ed42b70518c7917b49ee51
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/200490
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'common/extpower_falco.c')
| -rw-r--r-- | common/extpower_falco.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/common/extpower_falco.c b/common/extpower_falco.c index 664f2abe12..f7e0516e70 100644 --- a/common/extpower_falco.c +++ b/common/extpower_falco.c @@ -31,7 +31,7 @@ /* Console output macros */ #define CPUTS(outstr) cputs(CC_CHARGER, outstr) -#define CPRINTF(format, args...) cprintf(CC_CHARGER, format, ## args) +#define CPRINTS(format, args...) cprints(CC_CHARGER, format, ## args) /* Values for our supported adapters */ static const char * const ad_name[] = { @@ -156,11 +156,11 @@ static void ac_change_callback(void) { if (extpower_is_present()) { ac_adapter = identify_adapter(); - CPRINTF("[%T AC Adapter is %s (%dmv)]\n", + CPRINTS("AC Adapter is %s (%dmv)", ad_name[ac_adapter], last_mv); } else { ac_adapter = ADAPTER_UNKNOWN; - CPRINTF("[%T AC Adapter is not present]\n"); + CPRINTS("AC Adapter is not present"); /* Charger unavailable. Clear local flags */ } } @@ -172,7 +172,7 @@ static void set_turbo(int on) int tmp, r; if (ac_turbo != on) - CPRINTF("[%T turbo mode => %d]\n", on); + CPRINTS("turbo mode => %d", on); /* Set/clear turbo mode in charger */ r = charger_get_option(&tmp); @@ -198,7 +198,7 @@ static void set_turbo(int on) ac_turbo = on; return; bad: - CPRINTF("[%T ERROR: can't talk to charger: %d]\n", r); + CPRINTS("ERROR: can't talk to charger: %d", r); } |