diff options
| author | Randall Spangler <rspangler@chromium.org> | 2013-12-06 15:17:33 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-12-16 20:28:32 +0000 |
| commit | 05bd0cdec7a3132fda3127c3c9daeed0ebae0dae (patch) | |
| tree | 37720df1bbd03c8590a33212dfd147eab7b5430e /common/flash.c | |
| parent | 33ea7aa4739390c2cce578ac8310f0d7b5b3679c (diff) | |
| download | chrome-ec-05bd0cdec7a3132fda3127c3c9daeed0ebae0dae.tar.gz | |
Rename mixed-case config constants
This renames constants used in compiler conditionals to uppercase.
BOARD_foo
CHIP_foo
CHIP_FAMILY_foo
CHIP_VARIANT_foo
CORE_foo
Mixed-case constants are still defined by the makefile, but are now no
longer used. I will make one more pass in a week or so to catch any
that are part of someone else's CL, since otherwise this change might
silently merge correctly but result in incorrect compilation. Then I
will remove defining the mixed-case constants.
BUG=chromium:322144
BRANCH=none
TEST=Build all boards. Also, "git grep 'BOARD_[a-z]'" should return no
results (similarly for CHIP, CORE, etc.)
Change-Id: I6418412e9f7ec604a35c2d426d12475dd83e7076
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/179206
Reviewed-by: Vic Yang <victoryang@chromium.org>
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Diffstat (limited to 'common/flash.c')
| -rw-r--r-- | common/flash.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/common/flash.c b/common/flash.c index 2c613493bf..d39729980b 100644 --- a/common/flash.c +++ b/common/flash.c @@ -626,12 +626,12 @@ static int flash_command_protect(struct host_cmd_handler_args *args) if (!(r->flags & EC_FLASH_PROTECT_RO_NOW)) r->writable_flags |= EC_FLASH_PROTECT_RO_AT_BOOT; -#ifdef CHIP_FAMILY_stm32f +#ifdef CHIP_FAMILY_STM32F /* * TODO(crosbug.com/p/23762): Should ignore all-now on STM32F if WP * isn't asserted. We don't do this due to limitations in early snow * boards (lack of WP GPIO?) - in which case, this can either be - * restricted to BOARD_snow, or removed entirely. + * restricted to BOARD_SNOW, or removed entirely. */ r->valid_flags |= EC_FLASH_PROTECT_ALL_NOW; r->writable_flags |= EC_FLASH_PROTECT_ALL_NOW; |