summaryrefslogtreecommitdiff
path: root/common/gpio_commands.c
diff options
context:
space:
mode:
authorTom Hughes <tomhughes@chromium.org>2022-09-21 14:10:01 -0700
committerTom Hughes <tomhughes@chromium.org>2022-09-22 12:49:33 -0700
commit2bcf863b492fe7ed8105c853814dba6ed32ba719 (patch)
treefcf6ce5810f9ff9e3c8cce434812dd75492269ed /common/gpio_commands.c
parente5fb0b9ba488614b5684e640530f00821ab7b943 (diff)
parent28712dae9d7ed1e694f7622cc083afa71090d4d5 (diff)
downloadchrome-ec-2bcf863b492fe7ed8105c853814dba6ed32ba719.tar.gz
Merge remote-tracking branch cros/main into firmware-fpmcu-bloonchipper-releasefirmware-fpmcu-bloonchipper-release
Generated by: ./util/update_release_branch.py --board bloonchipper --relevant_paths_file ./util/fingerprint-relevant-paths.txt firmware- fpmcu-bloonchipper-release Relevant changes: git log --oneline e5fb0b9ba4..28712dae9d -- board/hatch_fp board/bloonchipper common/fpsensor docs/fingerprint driver/fingerprint util/getversion.sh ded9307b79 util/getversion.sh: Fix version when not in a git repo 956055e692 board: change Google USB vendor info 71b2ef709d Update license boilerplate text in source code files 33e11afda0 Revert "fpsensor: Build fpsensor source file with C++" c8d0360723 fpsensor: Build fpsensor source file with C++ bc113abd53 fpsensor: Fix g++ compiler error 150a58a0dc fpsensor: Fix fp_set_sensor_mode return type b33b5ce85b fpsensor: Remove nested designators for C++ compatibility 2e864b2539 tree-wide: const-ify argv for console commands 56d8b360f9 test: Add test for get ikm failure when seed not set 3a3d6c3690 test: Add test for fpsensor trivial key failure 233e6bbd08 fpsensor_crypto: Abstract calls to hmac_SHA256 0a041b285b docs/fingerprint: Typo correction c03fab67e2 docs/fingerprint: Fix the path of fputils.py 0b5d4baf5a util/getversion.sh: Fix empty file list handling 6e128fe760 FPMCU dev board environment with Satlab 3eb29b6aa5 builtin: Move ssize_t to sys/types.h 345d62ebd1 docs/fingerprint: Update power numbers for latest dartmonkey release c25ffdb316 common: Conditionally support printf %l and %i modifiers 9a3c514b45 test: Add a test to check if the debugger is connected 54e603413f Move standard library tests to their own file 43fa6b4bf8 docs/fingerprint: Update power numbers for latest bloonchipper release 25536f9a84 driver/fingerprint/fpc/bep/fpc_sensor_spi.c: Format with clang-format 4face99efd driver/fingerprint/fpc/libfp/fpc_sensor_pal.h: Format with clang-format 738de2b575 trng: Rename rand to trng_rand 14b8270edd docs/fingerprint: Update dragonclaw power numbers 0b268f93d1 driver/fingerprint/fpc/libfp/fpc_private.c: Format with clang-format f80da163f2 driver/fingerprint/fpc/libfp/fpc_private.h: Format with clang-format 5e9c85c9b1 driver/fingerprint/fpc/libfp/fpc_sensor_pal.c: Format with clang-format c1f9dd3cf8 driver/fingerprint/fpc/libfp/fpc_bio_algorithm.h: Format with clang-format eb1e1bed8d driver/fingerprint/fpc/libfp/fpc1145_private.h: Format with clang-format 6e7b611821 driver/fingerprint/fpc/bep/fpc_bio_algorithm.h: Format with clang-format e0589cd5e2 driver/fingerprint/fpc/bep/fpc1035_private.h: Format with clang-format 7905e556a0 common/fpsensor/fpsensor_crypto.c: Format with clang-format 21289d170c driver/fingerprint/fpc/bep/fpc1025_private.h: Format with clang-format 98a20f937e common/fpsensor/fpsensor_state.c: Format with clang-format a2d255d8af common/fpsensor/fpsensor.c: Format with clang-format 73055eeb3f driver/fingerprint/fpc/bep/fpc_private.c: Format with clang-format 0f7b5cb509 common/fpsensor/fpsensor_private.h: Format with clang-format 1ceade6e65 driver/fingerprint/fpc/bep/fpc_private.h: Format with clang-format dc3e9008b8 board/hatch_fp/board.h: Format with clang-format dca9d74321 Revert "trng: Rename rand to trng_rand" a6b0b3554f trng: Rename rand to trng_rand 28d0b75b70 third_party/boringssl: Remove unused header BRANCH=None BUG=b:246424843 b:234181908 b:244781166 b:234181908 b:244387210 BUG=b:242720240 chromium:1098010 b:180945056 b:236025198 b:234181908 BUG=b:234181908 b:237344361 b:131913998 b:236386294 b:234143158 BUG=b:234781655 b:215613183 b:242720910 TEST=`make -j buildall` TEST=./test/run_device_tests.py --board bloonchipper Test "aes": PASSED Test "cec": PASSED Test "cortexm_fpu": PASSED Test "crc": PASSED Test "flash_physical": PASSED Test "flash_write_protect": PASSED Test "fpsensor_hw": PASSED Test "fpsensor_spi_ro": PASSED Test "fpsensor_spi_rw": PASSED Test "fpsensor_uart_ro": PASSED Test "fpsensor_uart_rw": PASSED Test "mpu_ro": PASSED Test "mpu_rw": PASSED Test "mutex": PASSED Test "pingpong": PASSED Test "printf": PASSED Test "queue": PASSED Test "rollback_region0": PASSED Test "rollback_region1": PASSED Test "rollback_entropy": PASSED Test "rtc": PASSED Test "sha256": PASSED Test "sha256_unrolled": PASSED Test "static_if": PASSED Test "stdlib": PASSED Test "system_is_locked_wp_on": PASSED Test "system_is_locked_wp_off": PASSED Test "timer_dos": PASSED Test "utils": PASSED Test "utils_str": PASSED Test "stm32f_rtc": PASSED Test "panic_data_bloonchipper_v2.0.4277": PASSED Test "panic_data_bloonchipper_v2.0.5938": PASSED Force-Relevant-Builds: all Signed-off-by: Tom Hughes <tomhughes@chromium.org> Change-Id: I264ad0ffe7afcd507a1e483c6e934a9c4fea47c3
Diffstat (limited to 'common/gpio_commands.c')
-rw-r--r--common/gpio_commands.c53
1 files changed, 25 insertions, 28 deletions
diff --git a/common/gpio_commands.c b/common/gpio_commands.c
index b044524797..d6257ea61d 100644
--- a/common/gpio_commands.c
+++ b/common/gpio_commands.c
@@ -1,4 +1,4 @@
-/* Copyright 2013 The Chromium OS Authors. All rights reserved.
+/* Copyright 2013 The ChromiumOS Authors
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
@@ -67,8 +67,13 @@ static enum ec_error_list set(const char *name, int value)
if (!gpio_is_implemented(signal))
return EC_ERROR_INVAL;
- if (!(gpio_get_default_flags(signal) & GPIO_OUTPUT))
- return EC_ERROR_INVAL;
+ if (IS_ENABLED(CONFIG_GPIO_GET_EXTENDED)) {
+ if (!(gpio_get_flags(signal) & GPIO_OUTPUT))
+ return EC_ERROR_INVAL;
+ } else {
+ if (!(gpio_get_default_flags(signal) & GPIO_OUTPUT))
+ return EC_ERROR_INVAL;
+ }
gpio_set_level(signal, value);
@@ -78,23 +83,18 @@ static enum ec_error_list set(const char *name, int value)
/* Console commands */
struct gpio_flag_description {
- const int bitfield;
- const char* name;
+ const int bitfield;
+ const char *name;
};
__maybe_unused static const struct gpio_flag_description gpio_descriptions[] = {
- {GPIO_INPUT, "I"},
- {GPIO_OUTPUT, "O"},
- {GPIO_LOW, "L"},
- {GPIO_HIGH, "H"},
- {GPIO_OPEN_DRAIN, "ODR"},
- {GPIO_PULL_UP, "PU"},
- {GPIO_PULL_DOWN, "PD"},
- {GPIO_SEL_1P8V, "1P8"},
+ { GPIO_INPUT, "I" }, { GPIO_OUTPUT, "O" },
+ { GPIO_LOW, "L" }, { GPIO_HIGH, "H" },
+ { GPIO_OPEN_DRAIN, "ODR" }, { GPIO_PULL_UP, "PU" },
+ { GPIO_PULL_DOWN, "PD" }, { GPIO_SEL_1P8V, "1P8" },
#ifndef CONFIG_ZEPHYR
- {GPIO_ANALOG, "A"},
- {GPIO_ALTERNATE, "ALT"},
- {GPIO_LOCKED, "LCK"}
+ { GPIO_ANALOG, "A" }, { GPIO_ALTERNATE, "ALT" },
+ { GPIO_LOCKED, "LCK" }
#endif
};
@@ -103,12 +103,13 @@ static void print_gpio_info(int gpio)
int changed, v, i;
if (!gpio_is_implemented(gpio))
- return; /* Skip unsupported signals */
+ return; /* Skip unsupported signals */
v = gpio_get_level(gpio);
changed = last_val_changed(gpio, v);
- /* Split the printf call into multiple calls to reduce the stack usage. */
+ /* Split the printf call into multiple calls to reduce the stack usage.
+ */
ccprintf(" %d%c ", v, (changed ? '*' : ' '));
if (IS_ENABLED(CONFIG_CMD_GPIO_EXTENDED)) {
@@ -126,7 +127,7 @@ static void print_gpio_info(int gpio)
cflush();
}
-static int command_gpio_get(int argc, char **argv)
+static int command_gpio_get(int argc, const char **argv)
{
int i;
@@ -143,18 +144,17 @@ static int command_gpio_get(int argc, char **argv)
/* Otherwise print them all */
for (i = 0; i < GPIO_COUNT; i++) {
if (!gpio_is_implemented(i))
- continue; /* Skip unsupported signals */
+ continue; /* Skip unsupported signals */
print_gpio_info(i);
}
return EC_SUCCESS;
}
-DECLARE_SAFE_CONSOLE_COMMAND(gpioget, command_gpio_get,
- "[name]",
+DECLARE_SAFE_CONSOLE_COMMAND(gpioget, command_gpio_get, "[name]",
"Read GPIO value(s)");
-static int command_gpio_set(int argc, char **argv)
+static int command_gpio_set(int argc, const char **argv)
{
#ifdef CONFIG_CMD_GPIO_EXTENDED
int gpio;
@@ -217,9 +217,7 @@ DECLARE_CONSOLE_COMMAND_FLAGS(gpioset, command_gpio_set,
#else
"name <0 | 1>",
#endif
- "Set a GPIO",
- CMD_FLAG_RESTRICTED
-);
+ "Set a GPIO", CMD_FLAG_RESTRICTED);
/*****************************************************************************/
/* Host commands */
@@ -262,7 +260,7 @@ static enum ec_status gpio_command_get(struct host_cmd_handler_args *args)
i = p_v1->get_info.index;
len = strlen(gpio_get_name(i));
- memcpy(r_v1->get_info.name, gpio_get_name(i), len+1);
+ memcpy(r_v1->get_info.name, gpio_get_name(i), len + 1);
r_v1->get_info.val = gpio_get_level(i);
r_v1->get_info.flags = gpio_get_default_flags(i);
args->response_size = sizeof(r_v1->get_info);
@@ -272,7 +270,6 @@ static enum ec_status gpio_command_get(struct host_cmd_handler_args *args)
}
return EC_RES_SUCCESS;
-
}
DECLARE_HOST_COMMAND(EC_CMD_GPIO_GET, gpio_command_get,
EC_VER_MASK(0) | EC_VER_MASK(1));