diff options
| author | Randall Spangler <rspangler@chromium.org> | 2012-05-25 13:17:21 -0700 |
|---|---|---|
| committer | Randall Spangler <rspangler@chromium.org> | 2012-05-25 13:34:06 -0700 |
| commit | e704c712ad473160e97717f139ab3929bcd249c1 (patch) | |
| tree | 1b87c7ad05a1e97bd04326adc7f6b6239407b10e /common/gpio_commands.c | |
| parent | 89e1d5a1219c87d90e1362716f799b16aad5c921 (diff) | |
| download | chrome-ec-e704c712ad473160e97717f139ab3929bcd249c1.tar.gz | |
Better help for console commands
Additional help messages and usage are gated by
CONFIG_CONSOLE_CMDHELP, so we can turn it on if there's space (adds
about 3KB to image size) and turn it off when there isn't.
Signed-off-by: Randall Spangler <rspangler@chromium.org>
BUG=none
TEST=manual
1) help
2) help list
3) help gpioset
4) gpioset -> wrong number of params
5) gpioset fred 0 -> param1 bad
6) gpioset cpu_prochot fred -> param2 bad
Change-Id: Ibe99f37212020f763ebe65a068e6aa83a809a370
Diffstat (limited to 'common/gpio_commands.c')
| -rw-r--r-- | common/gpio_commands.c | 22 |
1 files changed, 14 insertions, 8 deletions
diff --git a/common/gpio_commands.c b/common/gpio_commands.c index ca8487533d..3327e9ae9c 100644 --- a/common/gpio_commands.c +++ b/common/gpio_commands.c @@ -58,7 +58,7 @@ static int command_gpio_get(int argc, char **argv) if (argc == 2) { i = find_signal_by_name(argv[1]); if (i == GPIO_COUNT) - return EC_ERROR_INVAL; + return EC_ERROR_PARAM1; g = gpio_list + i; v = gpio_get_level(i); changed = last_val_changed(i, v); @@ -82,7 +82,10 @@ static int command_gpio_get(int argc, char **argv) } return EC_SUCCESS; } -DECLARE_CONSOLE_COMMAND(gpioget, command_gpio_get); +DECLARE_CONSOLE_COMMAND(gpioget, command_gpio_get, + "[name]", + "Read GPIO value(s)", + NULL); static int command_gpio_set(int argc, char **argv) @@ -92,23 +95,26 @@ static int command_gpio_set(int argc, char **argv) int v, i; if (argc < 3) - return EC_ERROR_INVAL; + return EC_ERROR_PARAM_COUNT; i = find_signal_by_name(argv[1]); if (i == GPIO_COUNT) - return EC_ERROR_INVAL; + return EC_ERROR_PARAM1; g = gpio_list + i; if (!g->mask) - return EC_ERROR_INVAL; + return EC_ERROR_PARAM1; if (!(g->flags & GPIO_OUTPUT)) - return EC_ERROR_INVAL; + return EC_ERROR_PARAM1; v = strtoi(argv[2], &e, 0); if (*e) - return EC_ERROR_INVAL; + return EC_ERROR_PARAM2; return gpio_set_level(i, v); } -DECLARE_CONSOLE_COMMAND(gpioset, command_gpio_set); +DECLARE_CONSOLE_COMMAND(gpioset, command_gpio_set, + "name <0 | 1>", + "Set a GPIO", + NULL); |