diff options
| author | Randall Spangler <rspangler@chromium.org> | 2012-05-25 13:17:21 -0700 |
|---|---|---|
| committer | Randall Spangler <rspangler@chromium.org> | 2012-05-25 13:34:06 -0700 |
| commit | e704c712ad473160e97717f139ab3929bcd249c1 (patch) | |
| tree | 1b87c7ad05a1e97bd04326adc7f6b6239407b10e /common/host_event_commands.c | |
| parent | 89e1d5a1219c87d90e1362716f799b16aad5c921 (diff) | |
| download | chrome-ec-e704c712ad473160e97717f139ab3929bcd249c1.tar.gz | |
Better help for console commands
Additional help messages and usage are gated by
CONFIG_CONSOLE_CMDHELP, so we can turn it on if there's space (adds
about 3KB to image size) and turn it off when there isn't.
Signed-off-by: Randall Spangler <rspangler@chromium.org>
BUG=none
TEST=manual
1) help
2) help list
3) help gpioset
4) gpioset -> wrong number of params
5) gpioset fred 0 -> param1 bad
6) gpioset cpu_prochot fred -> param2 bad
Change-Id: Ibe99f37212020f763ebe65a068e6aa83a809a370
Diffstat (limited to 'common/host_event_commands.c')
| -rw-r--r-- | common/host_event_commands.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/common/host_event_commands.c b/common/host_event_commands.c index 70ee5a102c..507d603f7b 100644 --- a/common/host_event_commands.c +++ b/common/host_event_commands.c @@ -20,7 +20,7 @@ static int command_host_event(int argc, char **argv) char *e; int i = strtoi(argv[2], &e, 0); if (*e) - return EC_ERROR_INVAL; + return EC_ERROR_PARAM2; if (!strcasecmp(argv[1], "set")) lpc_set_host_events(i); @@ -33,7 +33,7 @@ static int command_host_event(int argc, char **argv) else if (!strcasecmp(argv[1], "wake")) lpc_set_host_event_mask(LPC_HOST_EVENT_WAKE, i); else - return EC_ERROR_INVAL; + return EC_ERROR_PARAM1; } /* Print current SMI/SCI status */ @@ -46,7 +46,10 @@ static int command_host_event(int argc, char **argv) lpc_get_host_event_mask(LPC_HOST_EVENT_WAKE)); return EC_SUCCESS; } -DECLARE_CONSOLE_COMMAND(hostevent, command_host_event); +DECLARE_CONSOLE_COMMAND(hostevent, command_host_event, + "[set | clear | smi | sci | wake] [mask]", + "Print / set host event state", + NULL); /*****************************************************************************/ /* Host commands */ |