diff options
author | Vic Yang <victoryang@chromium.org> | 2014-05-19 15:03:27 -0700 |
---|---|---|
committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-05-21 20:32:17 +0000 |
commit | ffac23c0ea1bd4ff4568f5bd709a98f912b833a7 (patch) | |
tree | 362dd0ba205731aa07be97dd35b44b237799b23b /common/lid_switch.c | |
parent | 478361de694b1fb45abf3c38dafbbf7fd1aa5f71 (diff) | |
download | chrome-ec-ffac23c0ea1bd4ff4568f5bd709a98f912b833a7.tar.gz |
Add cprints() and ccprints()
Our code base contains a lot of debug messages in this pattern:
CPRINTF("[%T xxx]\n") or ccprintf("[%T xxx]\n")
The strings are taking up spaces in the EC binaries, so let's refactor
this by adding cprints() and ccprints().
cprints() is just like cprintf(), except that it adds the brackets
and the timestamp. ccprints() is equivalent to cprints(CC_CONSOLE, ...)
This saves us hundreds of bytes in EC binaries.
BUG=chromium:374575
TEST=Build and check flash size
BRANCH=None
Change-Id: Ifafe8dc1b80e698b28ed42b70518c7917b49ee51
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/200490
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'common/lid_switch.c')
-rw-r--r-- | common/lid_switch.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/common/lid_switch.c b/common/lid_switch.c index 80e3dbfbaa..a676524b81 100644 --- a/common/lid_switch.c +++ b/common/lid_switch.c @@ -16,7 +16,7 @@ /* Console output macros */ #define CPUTS(outstr) cputs(CC_SWITCH, outstr) -#define CPRINTF(format, args...) cprintf(CC_SWITCH, format, ## args) +#define CPRINTS(format, args...) cprints(CC_SWITCH, format, ## args) #define LID_DEBOUNCE_US (30 * MSEC) /* Debounce time for lid switch */ @@ -38,11 +38,11 @@ static int raw_lid_open(void) static void lid_switch_open(void) { if (debounced_lid_open) { - CPRINTF("[%T lid already open]\n"); + CPRINTS("lid already open"); return; } - CPRINTF("[%T lid open]\n"); + CPRINTS("lid open"); debounced_lid_open = 1; hook_notify(HOOK_LID_CHANGE); host_set_single_event(EC_HOST_EVENT_LID_OPEN); @@ -54,11 +54,11 @@ static void lid_switch_open(void) static void lid_switch_close(void) { if (!debounced_lid_open) { - CPRINTF("[%T lid already closed]\n"); + CPRINTS("lid already closed"); return; } - CPRINTF("[%T lid close]\n"); + CPRINTS("lid close"); debounced_lid_open = 0; hook_notify(HOOK_LID_CHANGE); host_set_single_event(EC_HOST_EVENT_LID_CLOSED); |