diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2019-03-11 16:07:55 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:42:56 -0700 |
| commit | ac77140b7f4f42075d2377fc9d956a636b05aacf (patch) | |
| tree | c64c6a30916ff741a2ab235141f7bd071cd54483 /common/lightbar.c | |
| parent | bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (diff) | |
| download | chrome-ec-ac77140b7f4f42075d2377fc9d956a636b05aacf.tar.gz | |
common: bit change 1 << constants with BIT(constants)
Mechanical replacement of bit operation where operand is a constant.
More bit operation exist, but prone to errors.
Reveal a bug in npcx:
chip/npcx/system-npcx7.c:114:54: error: conversion from 'long unsigned int' to 'uint8_t' {aka 'volatile unsigned char'} changes value from '16777215' to '255' [-Werror=overflow]
BUG=None
BRANCH=None
TEST=None
Change-Id: I006614026143fa180702ac0d1cc2ceb1b3c6eeb0
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1518660
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'common/lightbar.c')
| -rw-r--r-- | common/lightbar.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/common/lightbar.c b/common/lightbar.c index c7fed67e7e..c0dd35e56b 100644 --- a/common/lightbar.c +++ b/common/lightbar.c @@ -1322,7 +1322,7 @@ static uint32_t lightbyte_SET_COLOR_SINGLE(void) return EC_RES_INVALID_PARAM; for (i = 0; i < NUM_LEDS; i++) - if (led & (1 << i)) + if (led & BIT(i)) led_desc[i][control][color] = value; return EC_SUCCESS; @@ -1350,7 +1350,7 @@ static uint32_t lightbyte_SET_COLOR_RGB(void) return EC_RES_INVALID_PARAM; for (i = 0; i < NUM_LEDS; i++) - if (led & (1 << i)) { + if (led & BIT(i)) { led_desc[i][control][LB_COL_RED] = r; led_desc[i][control][LB_COL_GREEN] = g; led_desc[i][control][LB_COL_BLUE] = b; |