diff options
| author | Randall Spangler <rspangler@chromium.org> | 2012-05-25 13:17:21 -0700 |
|---|---|---|
| committer | Randall Spangler <rspangler@chromium.org> | 2012-05-25 13:34:06 -0700 |
| commit | e704c712ad473160e97717f139ab3929bcd249c1 (patch) | |
| tree | 1b87c7ad05a1e97bd04326adc7f6b6239407b10e /common/lightbar.c | |
| parent | 89e1d5a1219c87d90e1362716f799b16aad5c921 (diff) | |
| download | chrome-ec-e704c712ad473160e97717f139ab3929bcd249c1.tar.gz | |
Better help for console commands
Additional help messages and usage are gated by
CONFIG_CONSOLE_CMDHELP, so we can turn it on if there's space (adds
about 3KB to image size) and turn it off when there isn't.
Signed-off-by: Randall Spangler <rspangler@chromium.org>
BUG=none
TEST=manual
1) help
2) help list
3) help gpioset
4) gpioset -> wrong number of params
5) gpioset fred 0 -> param1 bad
6) gpioset cpu_prochot fred -> param2 bad
Change-Id: Ibe99f37212020f763ebe65a068e6aa83a809a370
Diffstat (limited to 'common/lightbar.c')
| -rw-r--r-- | common/lightbar.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/common/lightbar.c b/common/lightbar.c index 40adeff920..e440b04620 100644 --- a/common/lightbar.c +++ b/common/lightbar.c @@ -832,10 +832,10 @@ static int command_lightbar(int argc, char **argv) return 0; } num = 0xff & strtoi(argv[2], &e, 16); - if (e && *e) + if (*e) num = find_msg_by_name(argv[2]); if (num >= LIGHTBAR_NUM_SEQUENCES) - return EC_ERROR_INVAL; + return EC_ERROR_PARAM2; lightbar_sequence(num); return EC_SUCCESS; } @@ -867,4 +867,7 @@ static int command_lightbar(int argc, char **argv) return EC_ERROR_INVAL; } -DECLARE_CONSOLE_COMMAND(lightbar, command_lightbar); +DECLARE_CONSOLE_COMMAND(lightbar, command_lightbar, + "[on | off | init | brightness | seq] | [ctrl reg val]", + "Get/set lightbar state", + NULL); |