diff options
author | Yilun Lin <yllin@google.com> | 2018-09-08 00:25:31 +0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2018-09-13 06:13:50 -0700 |
commit | 25091ec77eb8bec64011cd340fb01d3b63b88446 (patch) | |
tree | 06386ea5434085f169bd317292f713323981625f /common/mag_cal.c | |
parent | 8faef60c20ae6ffa4414fe9f4b47e6d0d8597348 (diff) | |
download | chrome-ec-25091ec77eb8bec64011cd340fb01d3b63b88446.tar.gz |
type: Rename mat33_t to mat33_float_t
Naming of many vector types and matrix types are not clear enough.
For example, we have:
vector_3_t, which is a vector of three int.
vec3_t, which is a vector of three float.
size4_t, which is a vector of four size_t.
mat33_t, which is a 3x3 matrix of float.
matrix_3x3_t, which is a 3x3 matrix of fixed point.
Besides, we have types like int8_t, uint16_t types.
To clearly distinguished types, the CL propose to,
For vector types, naming should be `$type + 'v' + $num + '_t'`:
vector_3_t becomes intv3_t
vec3_t becomes floatv3_t
vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet)
For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the
matrix size:
matrix_3x3_t becomes mat33_fp_t # fp: fixed point
mat33_t becomes mat33_float_t
TEST=make buildall -j
BUG=b:114662791
Change-Id: Ia601bfc9f9fb311f6ca91bfa2e8fa34259ed6c5b
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1215447
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'common/mag_cal.c')
-rw-r--r-- | common/mag_cal.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/common/mag_cal.c b/common/mag_cal.c index 08d5f7afd2..160530c2b9 100644 --- a/common/mag_cal.c +++ b/common/mag_cal.c @@ -34,9 +34,9 @@ */ static int moc_eigen_test(struct mag_cal_t *moc) { - mat33_t S; + mat33_float_t S; floatv3_t eigenvals; - mat33_t eigenvecs; + mat33_float_t eigenvecs; float evmax, evmin, evmag; int eigen_pass; @@ -48,7 +48,7 @@ static int moc_eigen_test(struct mag_cal_t *moc) S[1][2] = S[2][1] = moc->acc[1][2] - moc->acc[1][3] * moc->acc[2][3]; S[2][2] = moc->acc[2][2] - moc->acc[2][3] * moc->acc[2][3]; - mat33_get_eigenbasis(S, eigenvals, eigenvecs); + mat33_float_get_eigenbasis(S, eigenvals, eigenvecs); evmax = (eigenvals[X] > eigenvals[Y]) ? eigenvals[X] : eigenvals[Y]; evmax = (eigenvals[Z] > evmax) ? eigenvals[Z] : evmax; |