diff options
| author | Simon Glass <sjg@chromium.org> | 2012-06-03 10:45:09 -0700 |
|---|---|---|
| committer | Gerrit <chrome-bot@google.com> | 2012-06-21 06:01:22 -0700 |
| commit | d5cb02614225fc6f50b2fa806b1bb07a4c571008 (patch) | |
| tree | 20af4aabb58848aef5c8426efd87cf93fc989775 /common/main.c | |
| parent | 80fa2da908d4f03b6f1bdf4da5876aff20af88cb (diff) | |
| download | chrome-ec-d5cb02614225fc6f50b2fa806b1bb07a4c571008.tar.gz | |
Enable checking for divide by 0 and alignment faults
These likely indicate errors, so we shold trap them. Possibly this
should be reconsidered for production.
BUG=chrome-os-partner:10148
TEST=manual:
build on all boards
build and boot on snow with a special rw command containing a division
by 0. See that it is trapped:
> rw 0
=== EXCEPTION: 03 ====== xPSR: 01000000 ===========
r0 :0000000b r1 :08005eba r2 :00000000 r3 :20001048
r4 :00000000 r5 :08004fd4 r6 :08004f8c r7 :200012a8
r8 :08004fd4 r9 :00000002 r10:00000000 r11:00000000
r12:00000000 sp :200009a0 lr :08002861 pc :0800368a
Divide by 0, Forced hard fault, Vector catch
mmfs = 02000000, shcsr = 00000000, hfsr = 40000000, dfsr = 00000008
Turn off the cpu_init() setup, and see that it is ignored.
> rw 0
read 0x0 = 0x00000000
>
Similarly, try an unaligned access with the rw command with this enabled:
> rw 1
=== EXCEPTION: 03 ====== xPSR: 01000000 ===========
r0 :0000000b r1 :00000041 r2 :00000001 r3 :200012ac
r4 :00000000 r5 :08004fd4 r6 :08004f8c r7 :200012a8
r8 :08004fd4 r9 :00000002 r10:00000000 r11:00000000
r12:00000000 sp :200009a0 lr :08002861 pc :08003686
Unaligned, Forced hard fault, Vector catch
mmfs = 01000000, shcsr = 00000000, hfsr = 40000000, dfsr = 00000008
but disabled it works:
> rw 1
read 0x1 = 0x5d200010
>
Change-Id: Id84f737301e467b3b56a7ac22790e55d672df7d8
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/25410
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'common/main.c')
| -rw-r--r-- | common/main.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/common/main.c b/common/main.c index d807f17101..0feefee7e9 100644 --- a/common/main.c +++ b/common/main.c @@ -6,6 +6,7 @@ */ #include "clock.h" +#include "cpu.h" #include "config.h" #include "eeprom.h" #include "eoption.h" @@ -65,6 +66,7 @@ int main(void) timer_init(); /* Main initialization stage. Modules may enable interrupts here. */ + cpu_init(); /* Initialize UART. uart_printf(), etc. may now be used. */ uart_init(); |