diff options
author | Yilun Lin <yllin@google.com> | 2018-09-08 00:08:36 +0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2018-09-13 06:13:48 -0700 |
commit | 4c1de11ed14cff24335b370f022bee598cd20ee8 (patch) | |
tree | 39c3e847a3b7ee03488048ca1190bd1762c2712d /common/mat33.c | |
parent | c4a842a78c778e7c15cd3f78ae354e4d21a85ae9 (diff) | |
download | chrome-ec-4c1de11ed14cff24335b370f022bee598cd20ee8.tar.gz |
type: Rename vec3_t to floatv3_t.
Naming of many vector types and matrix types are not clear enough.
For example, we have:
vector_3_t, which is a vector of three int.
vec3_t, which is a vector of three float.
size4_t, which is a vector of four size_t.
mat33_t, which is a 3x3 matrix of float.
matrix_3x3_t, which is a 3x3 matrix of fixed point.
Besides, we have types like int8_t, uint16_t types.
To clearly distinguished types, the CL propose to,
For vector types, naming should be `$type + 'v' + $num + '_t'`:
vector_3_t becomes intv3_t
vec3_t becomes floatv3_t
vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet)
For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the
matrix size:
matrix_3x3_t becomes mat33_fp_t # fp: fixed point
mat33_t becomes mat33_float_t
TEST=make buildall -j
BUG=b:114662791
Change-Id: I8cac6a7c0abe3d462326291b76b1ed44ce6c9a9c
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1215443
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'common/mat33.c')
-rw-r--r-- | common/mat33.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/mat33.c b/common/mat33.c index 8317ee8a97..17938c0c4f 100644 --- a/common/mat33.c +++ b/common/mat33.c @@ -55,7 +55,7 @@ void mat33_swap_rows(mat33_t A, const size_t i, const size_t j) * The i-th eigenvalue corresponds to the eigenvector in the i-th _row_ of * "eigenvecs". */ -void mat33_get_eigenbasis(mat33_t S, vec3_t e_vals, mat33_t e_vecs) +void mat33_get_eigenbasis(mat33_t S, floatv3_t e_vals, mat33_t e_vecs) { const size_t N = 3; size3_t ind; |