diff options
author | Yilun Lin <yllin@google.com> | 2018-09-08 00:31:36 +0800 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2018-09-13 06:13:51 -0700 |
commit | cb49a07fd350d9b513b019f755730d298bf719e7 (patch) | |
tree | 49057db244ea0b103c1026e4b9aea2ce5037af1e /common/math_util.c | |
parent | c857c83cca204ab23e5d355ac1751b3cd7d95fb8 (diff) | |
download | chrome-ec-cb49a07fd350d9b513b019f755730d298bf719e7.tar.gz |
type: Rename matrix_3x3_t to mat33_fp_t
Naming of many vector types and matrix types are not clear enough.
For example, we have:
vector_3_t, which is a vector of three int.
vec3_t, which is a vector of three float.
size4_t, which is a vector of four size_t.
mat33_t, which is a 3x3 matrix of float.
matrix_3x3_t, which is a 3x3 matrix of fixed point.
Besides, we have types like int8_t, uint16_t types.
To clearly distinguished types, the CL propose to,
For vector types, naming should be `$type + 'v' + $num + '_t'`:
vector_3_t becomes intv3_t
vec3_t becomes floatv3_t
vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet)
For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the
matrix size:
matrix_3x3_t becomes mat33_fp_t # fp: fixed point
mat33_t becomes mat33_float_t
TEST=make buildall -j
BUG=b:114662791
Change-Id: I51d88d44252184e4b7b3564236833b0b892edc39
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1215449
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'common/math_util.c')
-rw-r--r-- | common/math_util.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/common/math_util.c b/common/math_util.c index 4cdddb1eab..d0b5887199 100644 --- a/common/math_util.c +++ b/common/math_util.c @@ -176,7 +176,7 @@ fp_t cosine_of_angle_diff(const intv3_t v1, const intv3_t v2) * rotate a vector v * - support input v and output res are the same vector */ -void rotate(const intv3_t v, const matrix_3x3_t R, intv3_t res) +void rotate(const intv3_t v, const mat33_fp_t R, intv3_t res) { fp_inter_t t[3]; @@ -204,7 +204,7 @@ void rotate(const intv3_t v, const matrix_3x3_t R, intv3_t res) res[2] = FP_TO_INT(t[2]); } -void rotate_inv(const intv3_t v, const matrix_3x3_t R, intv3_t res) +void rotate_inv(const intv3_t v, const mat33_fp_t R, intv3_t res) { fp_inter_t t[3]; fp_t deter; |