diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2016-08-22 17:55:12 -0700 |
|---|---|---|
| committer | Bill Richardson <wfrichar@chromium.org> | 2016-08-24 16:30:10 +0000 |
| commit | bb15561db56728b83ee7fe35e534da7577a7729d (patch) | |
| tree | e586ee3b18c8fda464da38b42a06845f0d7f6786 /common/memory_commands.c | |
| parent | f322e32a3ec052be3f0c226145448fed63aa7ef9 (diff) | |
| download | chrome-ec-bb15561db56728b83ee7fe35e534da7577a7729d.tar.gz | |
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
Since pretty much always, we've declared console commands to take
a "longhelp" argument with detailed explanations of what the
command does. But since almost as long, we've never actually used
that argument for anything - we just silently throw it away in
the macro. There's only one command (usbchargemode) that even
thinks it defines that argument.
We're never going to use this, let's just get rid of it.
BUG=none
BRANCH=none
CQ-DEPEND=CL:*279060
CQ-DEPEND=CL:*279158
CQ-DEPEND=CL:*279037
TEST=make buildall; tested on Cr50 hardware
Everything builds. Since we never used this arg anyway, there had
better not be any difference in the result.
Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374163
Reviewed-by: Myles Watson <mylesgw@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'common/memory_commands.c')
| -rw-r--r-- | common/memory_commands.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/common/memory_commands.c b/common/memory_commands.c index da88c71a63..3cf7974e5e 100644 --- a/common/memory_commands.c +++ b/common/memory_commands.c @@ -108,8 +108,7 @@ static int command_mem_dump(int argc, char **argv) DECLARE_CONSOLE_COMMAND(md, command_mem_dump, "[.b|.h|.s] addr [count]", - "dump memory values, optionally specifying the format", - NULL); + "dump memory values, optionally specifying the format"); #endif /* CONFIG_CMD_MD */ static int command_read_word(int argc, char **argv) @@ -191,5 +190,4 @@ static int command_read_word(int argc, char **argv) DECLARE_CONSOLE_COMMAND (rw, command_read_word, "[.b|.h] addr [value]", - "Read or write a word in memory optionally specifying the size", - NULL); + "Read or write a word in memory optionally specifying the size"); |