diff options
| author | Yilun Lin <yllin@google.com> | 2018-09-08 00:06:09 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-09-13 06:13:47 -0700 |
| commit | c4a842a78c778e7c15cd3f78ae354e4d21a85ae9 (patch) | |
| tree | 6668b4fd3911769f0011b5b17512d66923eea5fc /common/motion_lid.c | |
| parent | e6344f8560bad936573be75f6b2810373c2cdb01 (diff) | |
| download | chrome-ec-c4a842a78c778e7c15cd3f78ae354e4d21a85ae9.tar.gz | |
type: Rename vector_3_t to intv3_t.
Naming of many vector types and matrix types are not clear enough.
For example, we have:
vector_3_t, which is a vector of three int.
vec3_t, which is a vector of three float.
size4_t, which is a vector of four size_t.
mat33_t, which is a 3x3 matrix of float.
matrix_3x3_t, which is a 3x3 matrix of fixed point.
Besides, we have types like int8_t, uint16_t types.
To clearly distinguished types, the CL propose to,
For vector types, naming should be `$type + 'v' + $num + '_t'`:
vector_3_t becomes intv3_t
vec3_t becomes floatv3_t
vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet)
For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the
matrix size:
matrix_3x3_t becomes mat33_fp_t # fp: fixed point
mat33_t becomes mat33_float_t
TEST=make buildall -j
BUG=b:114662791
Change-Id: I865aa3ecbab6cb97f8585a081a679adf00febe1d
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1215442
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'common/motion_lid.c')
| -rw-r--r-- | common/motion_lid.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/common/motion_lid.c b/common/motion_lid.c index 27213d2c7a..cc7b098339 100644 --- a/common/motion_lid.c +++ b/common/motion_lid.c @@ -213,17 +213,17 @@ static int motion_lid_set_tablet_mode(int reliable) * * @return flag representing if resulting lid angle calculation is reliable. */ -static int calculate_lid_angle(const vector_3_t base, const vector_3_t lid, +static int calculate_lid_angle(const intv3_t base, const intv3_t lid, int *lid_angle) { - vector_3_t v; + intv3_t v; fp_t lid_to_base_fp, cos_lid_90, cos_lid_270; fp_t lid_to_base, base_to_hinge; fp_t denominator; int reliable = 1; int base_magnitude2, lid_magnitude2; int base_range, lid_range, i; - vector_3_t scaled_base, scaled_lid; + intv3_t scaled_base, scaled_lid; /* * The angle between lid and base is: @@ -422,9 +422,9 @@ void motion_lid_calc(void) * because calculate_lid_angle assumes when the lid is closed, that * the lid and base accelerometer data matches */ - vector_3_t lid = { accel_lid->xyz[X], - accel_lid->xyz[Y] * -1, - accel_lid->xyz[Z] * -1}; + intv3_t lid = { accel_lid->xyz[X], + accel_lid->xyz[Y] * -1, + accel_lid->xyz[Z] * -1}; /* Calculate angle of lid accel. */ lid_angle_is_reliable = calculate_lid_angle( accel_base->xyz, lid, |