diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2015-08-25 18:22:24 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2015-08-29 00:04:15 -0700 |
| commit | 7a2299163b7769b546db53c0dd225eee9e0a0df1 (patch) | |
| tree | 6fed3596ec94354b08d85ce2b65621aedd2794e2 /common/motion_sense.c | |
| parent | 252dce9bd3d70b09e33aba17580ad11d1203ee73 (diff) | |
| download | chrome-ec-7a2299163b7769b546db53c0dd225eee9e0a0df1.tar.gz | |
driver: change get_ interface.
Simplify sensor get_data_rate, get_range and get_resolution.
Error code was not checked and these functions as currently implemented
have no reason to fail.
BRANCH=ryu,samus,cyan,strago
BUG=chromium:513458
TEST=Check on ryu, compile
Change-Id: I40dca41cee29a19f65b2f84d434b4c19eb6cbf3c
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/295635
Reviewed-by: Sheng-liang Song <ssl@chromium.org>
Diffstat (limited to 'common/motion_sense.c')
| -rw-r--r-- | common/motion_sense.c | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/common/motion_sense.c b/common/motion_sense.c index 40d922d1f7..64179750f3 100644 --- a/common/motion_sense.c +++ b/common/motion_sense.c @@ -119,8 +119,7 @@ static void motion_sense_get_fifo_info( static inline int motion_sensor_time_to_read(const timestamp_t *ts, const struct motion_sensor_t *sensor) { - int rate; - sensor->drv->get_data_rate(sensor, &rate); + int rate = sensor->drv->get_data_rate(sensor); if (rate == 0) return 0; /* @@ -703,7 +702,7 @@ static int host_cmd_motion_sense(struct host_cmd_handler_args *args) } - sensor->drv->get_data_rate(sensor, &data); + data = sensor->drv->get_data_rate(sensor); /* Save configuration parameter: ODR */ sensor->runtime_config.odr = data; @@ -732,7 +731,7 @@ static int host_cmd_motion_sense(struct host_cmd_handler_args *args) } } - sensor->drv->get_range(sensor, &data); + data = sensor->drv->get_range(sensor); /* Save configuration parameter: range */ sensor->runtime_config.range = data; @@ -885,8 +884,8 @@ static int command_accelrange(int argc, char **argv) round) == EC_ERROR_INVAL) return EC_ERROR_PARAM2; } else { - sensor->drv->get_range(sensor, &data); - ccprintf("Range for sensor %d: %d\n", id, data); + ccprintf("Range for sensor %d: %d\n", id, + sensor->drv->get_range(sensor)); } return EC_SUCCESS; @@ -932,8 +931,8 @@ static int command_accelresolution(int argc, char **argv) == EC_ERROR_INVAL) return EC_ERROR_PARAM2; } else { - sensor->drv->get_resolution(sensor, &data); - ccprintf("Resolution for sensor %d: %d\n", id, data); + ccprintf("Resolution for sensor %d: %d\n", id, + sensor->drv->get_resolution(sensor)); } return EC_SUCCESS; @@ -982,8 +981,8 @@ static int command_accel_data_rate(int argc, char **argv) motion_sense_set_accel_interval( NULL, MAX_MOTION_SENSE_WAIT_TIME); } else { - sensor->drv->get_data_rate(sensor, &data); - ccprintf("Data rate for sensor %d: %d\n", id, data); + ccprintf("Data rate for sensor %d: %d\n", id, + sensor->drv->get_data_rate(sensor)); ccprintf("EC rate for sensor %d: %d\n", id, SENSOR_EC_RATE(sensor)); ccprintf("Current EC rate: %d\n", accel_interval); |