diff options
| author | Yilun Lin <yllin@google.com> | 2018-09-08 00:06:09 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-09-13 06:13:47 -0700 |
| commit | c4a842a78c778e7c15cd3f78ae354e4d21a85ae9 (patch) | |
| tree | 6668b4fd3911769f0011b5b17512d66923eea5fc /common/motion_sense.c | |
| parent | e6344f8560bad936573be75f6b2810373c2cdb01 (diff) | |
| download | chrome-ec-c4a842a78c778e7c15cd3f78ae354e4d21a85ae9.tar.gz | |
type: Rename vector_3_t to intv3_t.
Naming of many vector types and matrix types are not clear enough.
For example, we have:
vector_3_t, which is a vector of three int.
vec3_t, which is a vector of three float.
size4_t, which is a vector of four size_t.
mat33_t, which is a 3x3 matrix of float.
matrix_3x3_t, which is a 3x3 matrix of fixed point.
Besides, we have types like int8_t, uint16_t types.
To clearly distinguished types, the CL propose to,
For vector types, naming should be `$type + 'v' + $num + '_t'`:
vector_3_t becomes intv3_t
vec3_t becomes floatv3_t
vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet)
For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the
matrix size:
matrix_3x3_t becomes mat33_fp_t # fp: fixed point
mat33_t becomes mat33_float_t
TEST=make buildall -j
BUG=b:114662791
Change-Id: I865aa3ecbab6cb97f8585a081a679adf00febe1d
Signed-off-by: Yilun Lin <yllin@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1215442
Commit-Ready: Yilun Lin <yllin@chromium.org>
Tested-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'common/motion_sense.c')
| -rw-r--r-- | common/motion_sense.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/common/motion_sense.c b/common/motion_sense.c index 966c2da99e..8e1fe4e35b 100644 --- a/common/motion_sense.c +++ b/common/motion_sense.c @@ -37,7 +37,7 @@ * Orientation mode vectors, must match sequential ordering of * known orientations from enum motionsensor_orientation */ -const vector_3_t orientation_modes[] = { +const intv3_t orientation_modes[] = { [MOTIONSENSE_ORIENTATION_LANDSCAPE] = { 0, -1, 0 }, [MOTIONSENSE_ORIENTATION_PORTRAIT] = { 1, 0, 0 }, [MOTIONSENSE_ORIENTATION_UPSIDE_DOWN_PORTRAIT] = { -1, 0, 0 }, @@ -780,8 +780,8 @@ enum motionsensor_orientation motion_sense_remap_orientation( enum motionsensor_orientation orientation) { enum motionsensor_orientation rotated_orientation; - const vector_3_t *orientation_v; - vector_3_t rotated_orientation_v; + const intv3_t *orientation_v; + intv3_t rotated_orientation_v; if (orientation == MOTIONSENSE_ORIENTATION_UNKNOWN) return MOTIONSENSE_ORIENTATION_UNKNOWN; @@ -1646,7 +1646,7 @@ static int command_accel_read_xyz(int argc, char **argv) char *e; int id, n = 1, ret; struct motion_sensor_t *sensor; - vector_3_t v; + intv3_t v; if (argc < 2) return EC_ERROR_PARAM_COUNT; |