diff options
| author | Evan Green <evgreen@chromium.org> | 2019-10-01 14:07:03 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-10-05 00:47:58 +0000 |
| commit | e77ccb89c1b74a9ba3be47072d35e3e148d2a469 (patch) | |
| tree | d229a873d4e2cb6916c55d955b1e9a971052aa2b /common/panic_output.c | |
| parent | 1519095feaa933996ee413c87fd67de39d16213b (diff) | |
| download | chrome-ec-e77ccb89c1b74a9ba3be47072d35e3e148d2a469.tar.gz | |
Remove uses of %l
This change removes uses of %l from the EC side of the EC codebase.
This is done because the semantics of %l within printf have changed,
and there are concerns that new calls to printf will be cherry-picked
into old firmware branches without the printf changes. So, in
preparation for disallowing %l in master, remove occurrences of %l.
This change was done by manually fixing up anything found under the EC
directory with the following regex: %[0-9*.-]*l[^l]
Remember that anything on the host machine is fine as-is, since the host
printf never changed.
BUG=chromium:984041
TEST=make -j buildall
BRANCH=None
Change-Id: I2a97433ddab5bfb8a6031ca4ff1d3905289444e2
Signed-off-by: Evan Green <evgreen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1834603
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Diffstat (limited to 'common/panic_output.c')
| -rw-r--r-- | common/panic_output.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/common/panic_output.c b/common/panic_output.c index e8233d75cc..4c70b06679 100644 --- a/common/panic_output.c +++ b/common/panic_output.c @@ -194,12 +194,12 @@ static int command_crash(int argc, char **argv) volatile int zero = 0; cflush(); - ccprintf("%08lx", (long)1 / zero); + ccprintf("%08x", 1 / zero); } else if (!strcasecmp(argv[1], "udivzero")) { volatile int zero = 0; cflush(); - ccprintf("%08lx", (unsigned long)1 / zero); + ccprintf("%08x", 1 / zero); #ifdef CONFIG_CMD_STACKOVERFLOW } else if (!strcasecmp(argv[1], "stack")) { stack_overflow_recurse(1); |