diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2016-08-22 17:55:12 -0700 |
|---|---|---|
| committer | Bill Richardson <wfrichar@chromium.org> | 2016-08-24 16:30:10 +0000 |
| commit | bb15561db56728b83ee7fe35e534da7577a7729d (patch) | |
| tree | e586ee3b18c8fda464da38b42a06845f0d7f6786 /common/system.c | |
| parent | f322e32a3ec052be3f0c226145448fed63aa7ef9 (diff) | |
| download | chrome-ec-bb15561db56728b83ee7fe35e534da7577a7729d.tar.gz | |
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
Since pretty much always, we've declared console commands to take
a "longhelp" argument with detailed explanations of what the
command does. But since almost as long, we've never actually used
that argument for anything - we just silently throw it away in
the macro. There's only one command (usbchargemode) that even
thinks it defines that argument.
We're never going to use this, let's just get rid of it.
BUG=none
BRANCH=none
CQ-DEPEND=CL:*279060
CQ-DEPEND=CL:*279158
CQ-DEPEND=CL:*279037
TEST=make buildall; tested on Cr50 hardware
Everything builds. Since we never used this arg anyway, there had
better not be any difference in the result.
Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374163
Reviewed-by: Myles Watson <mylesgw@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'common/system.c')
| -rw-r--r-- | common/system.c | 27 |
1 files changed, 9 insertions, 18 deletions
diff --git a/common/system.c b/common/system.c index 6ef35be808..21458a432f 100644 --- a/common/system.c +++ b/common/system.c @@ -847,8 +847,7 @@ static int command_sysinfo(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(sysinfo, command_sysinfo, NULL, - "Print system info", - NULL); + "Print system info"); #ifdef CONFIG_CMD_SCRATCHPAD static int command_scratchpad(int argc, char **argv) @@ -868,8 +867,7 @@ static int command_scratchpad(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(scratchpad, command_scratchpad, "[val]", - "Get or set scratchpad value", - NULL); + "Get or set scratchpad value"); #endif /* CONFIG_CMD_SCRATCHPAD */ #ifdef CONFIG_HIBERNATE @@ -894,8 +892,7 @@ static int command_hibernate(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(hibernate, command_hibernate, "[sec] [usec]", - "Hibernate the EC", - NULL); + "Hibernate the EC"); #endif /* CONFIG_HIBERNATE */ /* @@ -996,8 +993,7 @@ static int command_version(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(version, command_version, NULL, - "Print versions", - NULL); + "Print versions"); static int command_sysjump(int argc, char **argv) { @@ -1037,8 +1033,7 @@ static int command_sysjump(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(sysjump, command_sysjump, "[RO | RW | addr | disable]", - "Jump to a system image or address", - NULL); + "Jump to a system image or address"); static int command_reboot(int argc, char **argv) { @@ -1072,8 +1067,7 @@ static int command_reboot(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(reboot, command_reboot, "[hard|soft] [preserve] [ap-off] [cancel]", - "Reboot the EC", - NULL); + "Reboot the EC"); static int command_system_lock(int argc, char **argv) { @@ -1082,8 +1076,7 @@ static int command_system_lock(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(syslock, command_system_lock, NULL, - "Lock the system, even if WP is disabled", - NULL); + "Lock the system, even if WP is disabled"); #ifdef CONFIG_LOW_POWER_IDLE /** @@ -1117,8 +1110,7 @@ static int command_sleepmask(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(sleepmask, command_sleepmask, "[ on | off | <sleep_mask>]", - "Display/force sleep mask.\nSee also 'dsleepmask'.", - NULL); + "Display/force sleep mask.\nSee also 'dsleepmask'."); #endif #ifdef CONFIG_CMD_JUMPTAGS @@ -1146,8 +1138,7 @@ static int command_jumptags(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(jumptags, command_jumptags, NULL, - "List jump tags", - NULL); + "List jump tags"); #endif /* CONFIG_CMD_JUMPTAGS */ /*****************************************************************************/ |