diff options
| author | Randall Spangler <rspangler@chromium.org> | 2012-06-25 14:41:08 -0700 |
|---|---|---|
| committer | Gerrit <chrome-bot@google.com> | 2012-06-25 15:37:41 -0700 |
| commit | 24395bcc874e61a712acd9e377fadbb3e1ba75dd (patch) | |
| tree | 37c4fa7e3a934a8f0f51536e97bed7c82071464e /common/system_common.c | |
| parent | faff1c6da61c293079bd4afb48ba465e1ad253b1 (diff) | |
| download | chrome-ec-24395bcc874e61a712acd9e377fadbb3e1ba75dd.tar.gz | |
Remove proto1 workarounds
At this point, EC code requires EVT. If you still have a proto1,
here's what'll break:
1) Keyboard recovery mode checks refresh key, and may read unreliably due
to proto1 silego reset circuit.
2) Lightbar may not start in the correct state.
3) EC 'hibernate' command will not work.
4) Board version may read incorrectly.
BUG=chrome-os-partner:9661
TEST=manual
1) powerbtn -> system powers on, lightbar displays proper sequence
2) version -> board version 1 (EVT)
3) power+refresh+esc -> system boots into recovery mode
4) power+refresh, then power button -> system reboots, then boots normally
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Change-Id: I699946e365d15ae38622b69da1a0241e72d05f61
Reviewed-on: https://gerrit.chromium.org/gerrit/26053
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Diffstat (limited to 'common/system_common.c')
| -rw-r--r-- | common/system_common.c | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/common/system_common.c b/common/system_common.c index 8952a455ff..573995f1f8 100644 --- a/common/system_common.c +++ b/common/system_common.c @@ -399,23 +399,6 @@ int system_get_board_version(void) int v = 0; #ifdef BOARD_link - /* Drive board revision GPIOs as outputs briefly. This clears any - * charge on the proto1 test points, since proto1 doesn't have - * stuffing resistors. */ - /* TODO: (crosbug.com/p/9559) remove when proto1 has been superseded by - * EVT */ - gpio_set_flags(GPIO_BOARD_VERSION1, GPIO_OUTPUT); - gpio_set_flags(GPIO_BOARD_VERSION2, GPIO_OUTPUT); - gpio_set_flags(GPIO_BOARD_VERSION3, GPIO_OUTPUT); - gpio_set_level(GPIO_BOARD_VERSION1, 0); - gpio_set_level(GPIO_BOARD_VERSION2, 0); - gpio_set_level(GPIO_BOARD_VERSION3, 0); - clock_wait_cycles(20); - gpio_set_flags(GPIO_BOARD_VERSION1, GPIO_INPUT); - gpio_set_flags(GPIO_BOARD_VERSION2, GPIO_INPUT); - gpio_set_flags(GPIO_BOARD_VERSION3, GPIO_INPUT); - clock_wait_cycles(20); - if (gpio_get_level(GPIO_BOARD_VERSION1)) v |= 0x01; if (gpio_get_level(GPIO_BOARD_VERSION2)) |