diff options
| author | Vic Yang <victoryang@chromium.org> | 2012-07-02 15:26:17 +0800 |
|---|---|---|
| committer | Gerrit <chrome-bot@google.com> | 2012-07-03 10:50:46 -0700 |
| commit | 24acac67a3ee3038145ff329a85c83fcf37ce84e (patch) | |
| tree | 6b57676014219ff9954672f9db17741ff63b7a5c /common/temp_sensor.c | |
| parent | d29ec56d41874eec163239a0344cbc74f3ad0708 (diff) | |
| download | chrome-ec-24acac67a3ee3038145ff329a85c83fcf37ce84e.tar.gz | |
Lower PECI baud rate and increase poll frequency
We see some intermittent failure on PECI read. This CL lower PECI baud
rate from 150K to 100K. Also, we poll PECI temperature 4 times per
second and average over last 4 values. We only report read error when
last 4 read all fails.
This CL also increases the external path delay, increases retry count,
and also enable timing negotiation error bypass.
BUG=chrome-os-partner:10382
TEST=Still able to read from all temperature sensors
Change-Id: I38cefeabd9e3eff4bb8e4df4138c4ffd49cd84a2
Reviewed-on: https://gerrit.chromium.org/gerrit/26554
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Tested-by: Vic Yang <victoryang@chromium.org>
Commit-Ready: Vic Yang <victoryang@chromium.org>
Diffstat (limited to 'common/temp_sensor.c')
| -rw-r--r-- | common/temp_sensor.c | 22 |
1 files changed, 16 insertions, 6 deletions
diff --git a/common/temp_sensor.c b/common/temp_sensor.c index c027fb560b..0cfcade505 100644 --- a/common/temp_sensor.c +++ b/common/temp_sensor.c @@ -54,19 +54,25 @@ int temp_sensor_powered(enum temp_sensor_id id) } -void poll_all_sensors(void) +void poll_slow_sensors(void) { + /* Poll every second */ #ifdef CONFIG_TMP006 tmp006_poll(); #endif -#ifdef CONFIG_PECI - peci_temp_sensor_poll(); -#endif #ifdef CHIP_lm4 chip_temp_sensor_poll(); #endif } +static void poll_fast_sensors(void) +{ + /* Poll every 1/4 second */ +#ifdef CONFIG_PECI + peci_temp_sensor_poll(); +#endif +} + static void update_lpc_mapped_memory(void) { @@ -91,10 +97,14 @@ static void update_lpc_mapped_memory(void) void temp_sensor_task(void) { + int i; while (1) { - poll_all_sensors(); + for (i = 0; i < 4; ++i) { + usleep(250000); + poll_fast_sensors(); + } + poll_slow_sensors(); update_lpc_mapped_memory(); - usleep(1000000); } } |