summaryrefslogtreecommitdiff
path: root/common/uart_buffering.c
diff options
context:
space:
mode:
authorAnton Staaf <robotboy@chromium.org>2016-03-23 12:45:28 -0700
committerchrome-bot <chrome-bot@chromium.org>2016-04-18 17:32:40 -0700
commit068cd0850684ee28a5a514e5a270edce2edb3979 (patch)
treee84f2316e37baa72f1c9611e665749d91a3ce8fd /common/uart_buffering.c
parent1e7c280491232110e1006d545f9a61ca05d469d5 (diff)
downloadchrome-ec-068cd0850684ee28a5a514e5a270edce2edb3979.tar.gz
Deferred: Use deferred_data instead of function pointer
Previously calls to hook_call_deferred were passed the function to call, which was then looked up in the .rodata.deferred section with a linear search. This linear search can be replaced with a subtract by passing the pointer to the deferred_data object created when DECLARE_DEFERRED was invoked. Signed-off-by: Anton Staaf <robotboy@chromium.org> BRANCH=None BUG=None CQ-DEPEND=CL:*255812 TEST=make buildall -j Change-Id: I951dd1541302875b102dd086154cf05591694440 Reviewed-on: https://chromium-review.googlesource.com/334315 Commit-Ready: Bill Richardson <wfrichar@chromium.org> Tested-by: Bill Richardson <wfrichar@chromium.org> Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Diffstat (limited to 'common/uart_buffering.c')
-rw-r--r--common/uart_buffering.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/common/uart_buffering.c b/common/uart_buffering.c
index 949c3968d6..c750a1ef6e 100644
--- a/common/uart_buffering.c
+++ b/common/uart_buffering.c
@@ -167,6 +167,9 @@ void uart_process_output(void)
#ifdef CONFIG_UART_RX_DMA
+void uart_process_input(void);
+DECLARE_DEFERRED(uart_process_input);
+
void uart_process_input(void)
{
static int fast_rechecks;
@@ -208,11 +211,11 @@ void uart_process_input(void)
*/
if (fast_rechecks) {
fast_rechecks--;
- hook_call_deferred(uart_process_input, RX_DMA_RECHECK_INTERVAL);
+ hook_call_deferred(&uart_process_input_data,
+ RX_DMA_RECHECK_INTERVAL);
}
}
DECLARE_HOOK(HOOK_TICK, uart_process_input, HOOK_PRIO_DEFAULT);
-DECLARE_DEFERRED(uart_process_input);
#else /* !CONFIG_UART_RX_DMA */