diff options
| author | Randall Spangler <rspangler@chromium.org> | 2012-10-23 14:12:25 -0700 |
|---|---|---|
| committer | Gerrit <chrome-bot@google.com> | 2012-10-23 16:49:29 -0700 |
| commit | e72788ef96e83ef9d6ac0b2593c7edd8139c9376 (patch) | |
| tree | 8eab899042c277b835310e9c35d9ee8180b14837 /common/usb_charge.c | |
| parent | 7cd4d4391d3abbd2272bf9b7459677a4fa99cd0c (diff) | |
| download | chrome-ec-e72788ef96e83ef9d6ac0b2593c7edd8139c9376.tar.gz | |
Hook functions no longer return values
Previously, all hook functions returned EC_SUCCESS, which was
meaningless because nothing ever looked at the return value. Changing
the return value to void saves ~100 bytes of code size and an equal
amount of source code size.
BUG=none
BRANCH=none
TEST=code still builds; link still boots
Change-Id: I2a636339894e5a804831244967a9c9d134df7d13
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/36372
Diffstat (limited to 'common/usb_charge.c')
| -rw-r--r-- | common/usb_charge.c | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/common/usb_charge.c b/common/usb_charge.c index 6f95d91101..c7332fab49 100644 --- a/common/usb_charge.c +++ b/common/usb_charge.c @@ -168,7 +168,7 @@ DECLARE_HOST_COMMAND(EC_CMD_USB_CHARGE_SET_MODE, /*****************************************************************************/ /* Hooks */ -static int usb_charge_preserve_state(void) +static void usb_charge_preserve_state(void) { struct usb_state state; @@ -177,11 +177,10 @@ static int usb_charge_preserve_state(void) system_add_jump_tag(USB_SYSJUMP_TAG, USB_HOOK_VERSION, sizeof(state), &state); - return EC_SUCCESS; } DECLARE_HOOK(HOOK_SYSJUMP, usb_charge_preserve_state, HOOK_PRIO_DEFAULT); -static int usb_charge_init(void) +static void usb_charge_init(void) { const struct usb_state *prev; int version, size; @@ -194,25 +193,19 @@ static int usb_charge_init(void) } else usb_charge_all_ports_off(); - - return EC_SUCCESS; } DECLARE_HOOK(HOOK_INIT, usb_charge_init, HOOK_PRIO_DEFAULT); - -static int usb_charge_resume(void) +static void usb_charge_resume(void) { /* Turn on USB ports on as we go into S0 from S3 or S5. */ usb_charge_all_ports_on(); - return EC_SUCCESS; } DECLARE_HOOK(HOOK_CHIPSET_RESUME, usb_charge_resume, HOOK_PRIO_DEFAULT); - -static int usb_charge_shutdown(void) +static void usb_charge_shutdown(void) { /* Turn on USB ports off as we go back to S5. */ usb_charge_all_ports_off(); - return EC_SUCCESS; } DECLARE_HOOK(HOOK_CHIPSET_SHUTDOWN, usb_charge_shutdown, HOOK_PRIO_DEFAULT); |