diff options
| author | Abe Levkoy <alevkoy@chromium.org> | 2020-06-03 11:06:53 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-06-11 19:44:59 +0000 |
| commit | b9203fa3b2b032c3aa7b2e3ccfb01dce7eea8f22 (patch) | |
| tree | 7969549ba4fdc71e0d4427765543330f8f40df11 /common/usb_pd_host_cmd.c | |
| parent | 7b2203f0e45e6dc653aec4bc4c5cd4b72e844b9f (diff) | |
| download | chrome-ec-b9203fa3b2b032c3aa7b2e3ccfb01dce7eea8f22.tar.gz | |
TCPMv2: Support mode entry for SOP' and SOP''
Add a transmit type parameter to functions involved in mode entry; also
add such a parameter to various functions calling those functions. For
DisplayPort-specific definitions or calls, specify SOP; we do not
currently support DisplayPort mode for cable plugs. For TCPMv1-specific
code, specify SOP. TCPMv1 generally assumes that the discovery/mode
structures are 1-dimensional, as they were previously, and changing that
is outside the scope of this CL.
BUG=b:155890173
TEST=Enter DP mode on Volteer with TCPMv2
TEST=Enter DP mode on Volteer with TCPMv1
TEST=Enter TBT mode on Volteer with TCPMV1
BRANCH=none
Change-Id: I8afc75b3f3be8939c4645058ac4a31f24c88fb9e
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2229279
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'common/usb_pd_host_cmd.c')
| -rw-r--r-- | common/usb_pd_host_cmd.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/common/usb_pd_host_cmd.c b/common/usb_pd_host_cmd.c index 8bd9f16aea..6e8afe761e 100644 --- a/common/usb_pd_host_cmd.c +++ b/common/usb_pd_host_cmd.c @@ -125,7 +125,7 @@ static enum ec_status hc_remote_pd_set_amode(struct host_cmd_handler_args *args) switch (p->cmd) { case PD_EXIT_MODE: - if (pd_dfp_exit_mode(p->port, p->svid, p->opos)) + if (pd_dfp_exit_mode(p->port, TCPC_TX_SOP, p->svid, p->opos)) pd_send_vdm(p->port, p->svid, CMD_EXIT_MODE | VDO_OPOS(p->opos), NULL, 0); else { @@ -134,7 +134,7 @@ static enum ec_status hc_remote_pd_set_amode(struct host_cmd_handler_args *args) } break; case PD_ENTER_MODE: - if (pd_dfp_enter_mode(p->port, p->svid, p->opos)) + if (pd_dfp_enter_mode(p->port, TCPC_TX_SOP, p->svid, p->opos)) pd_send_vdm(p->port, p->svid, CMD_ENTER_MODE | VDO_OPOS(p->opos), NULL, 0); break; @@ -190,10 +190,10 @@ static enum ec_status hc_remote_pd_get_amode(struct host_cmd_handler_args *args) r->opos = 0; memcpy(r->vdo, pd_get_mode_vdo(p->port, p->svid_idx, TCPC_TX_SOP), sizeof(uint32_t) * PDO_MODES); - modep = pd_get_amode_data(p->port, r->svid); + modep = pd_get_amode_data(p->port, TCPC_TX_SOP, r->svid); if (modep) - r->opos = pd_alt_mode(p->port, r->svid); + r->opos = pd_alt_mode(p->port, TCPC_TX_SOP, r->svid); args->response_size = sizeof(*r); return EC_RES_SUCCESS; |