diff options
| author | Diana Z <dzigterman@chromium.org> | 2020-04-04 21:51:10 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-04-08 22:39:59 +0000 |
| commit | a1369e5e1eb98bb0e25df3319b14bcb9cd2e64a4 (patch) | |
| tree | fd21811d883744f712f9e59afd1aa8ddd7cb700f /common/usb_pd_policy.c | |
| parent | 581e6f9a83d468d02f40c2c0d811fc25c73be54b (diff) | |
| download | chrome-ec-a1369e5e1eb98bb0e25df3319b14bcb9cd2e64a4.tar.gz | |
TCPMv2: Send VDM version according to PD rev set
Sets the VDM version field according to the PD revision being used for
the port and type. Also removes the pd_get_rev() declaration from the
usb_pd header as it's only used in the TCPMv1 protocol file.
BRANCH=None
BUG=b:150784275
TEST=on kindred with TCPMv2, confirm VMDs sent to PD 3.0 partner are
versioned as VDM 2.0 and PD 2.0 partner is versioned as VDM 1.0.
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ibff3f020ecf494773da7038c59d50667cd40bfa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2136904
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'common/usb_pd_policy.c')
| -rw-r--r-- | common/usb_pd_policy.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/common/usb_pd_policy.c b/common/usb_pd_policy.c index 8d371d4b44..9fd322f73d 100644 --- a/common/usb_pd_policy.c +++ b/common/usb_pd_policy.c @@ -808,7 +808,7 @@ int pd_svdm(int port, int cnt, uint32_t *payload, uint32_t **rpayload, payload[0] |= VDO_CMDT(CMDT_RSP_BUSY); rsize = 1; } - payload[0] |= VDO_SVDM_VERS(pd_get_vdo_ver(port)); + payload[0] |= VDO_SVDM_VERS(pd_get_vdo_ver(port, TCPC_TX_SOP)); } else if (cmd_type == CMDT_RSP_ACK) { #ifdef CONFIG_USB_PD_ALT_MODE_DFP struct svdm_amode_data *modep; @@ -1005,7 +1005,7 @@ int pd_svdm(int port, int cnt, uint32_t *payload, uint32_t **rpayload, } payload[0] |= VDO_CMDT(CMDT_INIT); - payload[0] |= VDO_SVDM_VERS(pd_get_vdo_ver(port)); + payload[0] |= VDO_SVDM_VERS(pd_get_vdo_ver(port, TCPC_TX_SOP)); #ifdef CONFIG_USB_PD_ALT_MODE_DFP } else if (cmd_type == CMDT_RSP_BUSY) { switch (cmd) { |