diff options
| author | Daisuke Nojiri <dnojiri@chromium.org> | 2019-10-21 10:07:48 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-02-09 08:31:43 +0000 |
| commit | 37151225f4d791204a75173eec64ebfdaf2cbdec (patch) | |
| tree | a9680e1fd0897c1ea6e0461055760c42944fdee7 /common/usb_pd_protocol.c | |
| parent | a4f7c8ef7c0b9b3206f67299414c2cbd2a5fe84a (diff) | |
| download | chrome-ec-37151225f4d791204a75173eec64ebfdaf2cbdec.tar.gz | |
EFS2: Implement Early Firmware Selection ver.2
EFS v1 allowed Chromeboxes to verify RW without AP. EFS v2 will bring
the benefts to Chromebooks, which are:
- Reduce RO dependency and presence. Allow more code to be updated
in the fields.
- Remove jumptag and workarounds needed for late sysjump.
Major imporvements over v1 are:
- No A/B slot required.
- No signature in RW or public key in RO.
- Rollback-attack protection.
- Verifies only RW being used instead of whole RW section.
For battery-equipped devices, additional benefts are:
- Immediate boot on drained battery.
- Support recovery mode regardless of battery condition.
- Faster charge in S5/G3.
EC-Cr50 communication is based on the shared UART (go/ec-cr50-comm).
EFS2 is documented in go/ec-efs2.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=chromium:1045217,chromium:141143112
BRANCH=none
TEST=Boot Helios in NORMAL/NO_BOOT/NO_BOOT_RECOVERY/RECOVERY mode.
TEST=Wake up EC from hibernate.
TEST=Make EC assert PACKET_MODE to wake up Cr50 from deepsleep.
Change-Id: I98a4fe1ecc59d106810a75daec3c424f953ff880
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2015357
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Commit-Queue: Daisuke Nojiri <dnojiri@chromium.org>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Auto-Submit: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'common/usb_pd_protocol.c')
| -rw-r--r-- | common/usb_pd_protocol.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/common/usb_pd_protocol.c b/common/usb_pd_protocol.c index 39154f3fe0..fea9d248a4 100644 --- a/common/usb_pd_protocol.c +++ b/common/usb_pd_protocol.c @@ -2813,13 +2813,10 @@ static void pd_init_tasks(void) #if defined(CONFIG_USB_PD_COMM_DISABLED) enable = 0; #elif defined(CONFIG_USB_PD_COMM_LOCKED) - /* Disable PD communication at init if we're in RO and locked. */ - if (!system_is_in_rw() && system_is_locked()) + /* Disable PD communication if we're in RO, WP is enabled, and EFS + * didn't register NO_BOOT. */ + if (!system_is_in_rw() && system_is_locked() && !vboot_allow_usb_pd()) enable = 0; -#ifdef CONFIG_VBOOT_EFS - if (vboot_need_pd_comm()) - enable = 1; -#endif #endif for (i = 0; i < board_get_usb_pd_port_count(); i++) pd_comm_enabled[i] = enable; |