diff options
| author | Vic Yang <victoryang@chromium.org> | 2014-05-19 15:03:27 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-05-21 20:32:17 +0000 |
| commit | ffac23c0ea1bd4ff4568f5bd709a98f912b833a7 (patch) | |
| tree | 362dd0ba205731aa07be97dd35b44b237799b23b /common/usb_port_power_dumb.c | |
| parent | 478361de694b1fb45abf3c38dafbbf7fd1aa5f71 (diff) | |
| download | chrome-ec-ffac23c0ea1bd4ff4568f5bd709a98f912b833a7.tar.gz | |
Add cprints() and ccprints()
Our code base contains a lot of debug messages in this pattern:
CPRINTF("[%T xxx]\n") or ccprintf("[%T xxx]\n")
The strings are taking up spaces in the EC binaries, so let's refactor
this by adding cprints() and ccprints().
cprints() is just like cprintf(), except that it adds the brackets
and the timestamp. ccprints() is equivalent to cprints(CC_CONSOLE, ...)
This saves us hundreds of bytes in EC binaries.
BUG=chromium:374575
TEST=Build and check flash size
BRANCH=None
Change-Id: Ifafe8dc1b80e698b28ed42b70518c7917b49ee51
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/200490
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'common/usb_port_power_dumb.c')
| -rw-r--r-- | common/usb_port_power_dumb.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/common/usb_port_power_dumb.c b/common/usb_port_power_dumb.c index 8c4081dd6d..feea23ed0a 100644 --- a/common/usb_port_power_dumb.c +++ b/common/usb_port_power_dumb.c @@ -16,7 +16,7 @@ #include "util.h" #define CPUTS(outstr) cputs(CC_USBCHARGE, outstr) -#define CPRINTF(format, args...) cprintf(CC_USBCHARGE, format, ## args) +#define CPRINTS(format, args...) cprints(CC_USBCHARGE, format, ## args) #define USB_SYSJUMP_TAG 0x5550 /* "UP" - Usb Port */ #define USB_HOOK_VERSION 1 @@ -54,7 +54,7 @@ static void usb_port_all_ports_off(void) int usb_port_set_mode(int port_id, enum usb_charge_mode mode) { - CPRINTF("[%T USB port p%d %d]\n", port_id, mode); + CPRINTS("USB port p%d %d", port_id, mode); if (port_id < 0 || port_id >= USB_PORT_COUNT) return EC_ERROR_INVAL; |