diff options
| author | Jett Rink <jettrink@chromium.org> | 2020-08-19 10:06:41 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-08-21 23:49:17 +0000 |
| commit | d6cfd2b302832928635e0a3d2c6b067766142a79 (patch) | |
| tree | 5a210dbae9b8f60bf1e752f33ee66e289861b81c /common/usbc/usb_prl_sm.c | |
| parent | 5c8501c341f1e73278a8f440c708c478911a6bda (diff) | |
| download | chrome-ec-d6cfd2b302832928635e0a3d2c6b067766142a79.tar.gz | |
usbc: remove PD_EVENT_SM in favor of task_wake
We have used both methods of waking up the PD tasks to process the next
state: PD_EVENT_SM and TASK_EVENT_WAKE. They effectively do the same
thing and it is more straightforward to only have one way to wake the
task up with the sole purpose of re-evaluating the current state.
BRANCH=none
BUG=none
TEST=No regressions on GRL testing.
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: I0fa79b82223e6b97eede4130480156949d79f365
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2363466
Reviewed-by: Edward Hill <ecgh@chromium.org>
Diffstat (limited to 'common/usbc/usb_prl_sm.c')
| -rw-r--r-- | common/usbc/usb_prl_sm.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/common/usbc/usb_prl_sm.c b/common/usbc/usb_prl_sm.c index 41e1a6b58f..788b5eeef0 100644 --- a/common/usbc/usb_prl_sm.c +++ b/common/usbc/usb_prl_sm.c @@ -456,7 +456,7 @@ void pd_execute_hard_reset(int port) PRL_HR_SET_FLAG(port, PRL_FLAGS_PORT_PARTNER_HARD_RESET); set_state_prl_hr(port, PRL_HR_RESET_LAYER); - task_set_event(PD_PORT_TO_TASK_ID(port), PD_EVENT_SM, 0); + task_wake(PD_PORT_TO_TASK_ID(port)); } void prl_execute_hard_reset(int port) @@ -467,7 +467,7 @@ void prl_execute_hard_reset(int port) PRL_HR_SET_FLAG(port, PRL_FLAGS_PE_HARD_RESET); set_state_prl_hr(port, PRL_HR_RESET_LAYER); - task_set_event(PD_PORT_TO_TASK_ID(port), PD_EVENT_SM, 0); + task_wake(PD_PORT_TO_TASK_ID(port)); } int prl_is_running(int port) @@ -530,7 +530,7 @@ void prl_set_debug_level(enum debug_level debug_level) void prl_hard_reset_complete(int port) { PRL_HR_SET_FLAG(port, PRL_FLAGS_HARD_RESET_COMPLETE); - task_set_event(PD_PORT_TO_TASK_ID(port), PD_EVENT_SM, 0); + task_wake(PD_PORT_TO_TASK_ID(port)); } void prl_send_ctrl_msg(int port, @@ -550,7 +550,7 @@ void prl_send_ctrl_msg(int port, PRL_TX_SET_FLAG(port, PRL_FLAGS_MSG_XMIT); #endif /* CONFIG_USB_PD_REV30 */ - task_set_event(PD_PORT_TO_TASK_ID(port), PD_EVENT_SM, 0); + task_wake(PD_PORT_TO_TASK_ID(port)); } void prl_send_data_msg(int port, @@ -569,7 +569,7 @@ void prl_send_data_msg(int port, PRL_TX_SET_FLAG(port, PRL_FLAGS_MSG_XMIT); #endif /* CONFIG_USB_PD_REV30 */ - task_set_event(PD_PORT_TO_TASK_ID(port), PD_EVENT_SM, 0); + task_wake(PD_PORT_TO_TASK_ID(port)); } #ifdef CONFIG_USB_PD_EXTENDED_MESSAGES @@ -582,7 +582,7 @@ void prl_send_ext_data_msg(int port, pdmsg[port].ext = 1; TCH_SET_FLAG(port, PRL_FLAGS_MSG_XMIT); - task_set_event(PD_PORT_TO_TASK_ID(port), PD_EVENT_SM, 0); + task_wake(PD_PORT_TO_TASK_ID(port)); } #endif /* CONFIG_USB_PD_EXTENDED_MESSAGES */ @@ -1032,7 +1032,7 @@ static void prl_tx_wait_for_phy_response_run(const int port) * This event reduces the time of informing the policy engine of * the transmission by one state machine cycle */ - task_set_event(PD_PORT_TO_TASK_ID(port), PD_EVENT_SM, 0); + task_wake(PD_PORT_TO_TASK_ID(port)); set_state_prl_tx(port, PRL_TX_WAIT_FOR_MESSAGE_REQUEST); } else if (get_time().val > prl_tx[port].tcpc_tx_timeout || prl_tx[port].xmit_status == TCPC_TX_COMPLETE_FAILED || @@ -2103,7 +2103,7 @@ static void prl_rx_wait_for_phy_message(const int port, int evt) pe_message_received(port); } - task_set_event(PD_PORT_TO_TASK_ID(port), PD_EVENT_SM, 0); + task_wake(PD_PORT_TO_TASK_ID(port)); } /* All necessary Protocol Transmit States (Section 6.11.2.2) */ |