summaryrefslogtreecommitdiff
path: root/common/version.c
diff options
context:
space:
mode:
authorJack Rosenthal <jrosenth@chromium.org>2019-05-01 14:08:33 -0600
committerChromeOS Commit Bot <chromeos-commit-bot@chromium.org>2019-05-07 21:32:43 +0000
commit50ca30ba9950251cd262c6d7002dee6bebf9cef5 (patch)
tree07b9eb57ed502e6e4d428384ea2a824165e2a499 /common/version.c
parent9363c1735d23ea6824895961fad6b989e5101adb (diff)
downloadchrome-ec-50ca30ba9950251cd262c6d7002dee6bebf9cef5.tar.gz
ish: ensure all CONFIGs are undef'ed in include/config.h
Some people have been bypassing the pre-submit checks: confs=($(grep -Eor "\bCONFIG_[A-Z_]*" chip/ish/config_chip.h | sort | uniq)) for opt in "${confs[@]}"; do grep "$opt" include/config.h >/dev/null || echo "$opt is not defined in include/config.h!" done >>> CONFIG_ISH_AON_SRAM_BASE_END is not defined in include/config.h! CONFIG_ISH_AON_SRAM_BASE_START is not defined in include/config.h! CONFIG_ISH_AON_SRAM_ROM_SIZE is not defined in include/config.h! CONFIG_ISH_AON_SRAM_ROM_START is not defined in include/config.h! CONFIG_ISH_AON_SRAM_SIZE is not defined in include/config.h! CONFIG_ISH_SRAM_BANKS is not defined in include/config.h! CONFIG_ISH_SRAM_BANK_SIZE is not defined in include/config.h! CONFIG_ISH_SRAM_BASE_END is not defined in include/config.h! CONFIG_ISH_SRAM_BASE_START is not defined in include/config.h! CONFIG_ISH_SRAM_SIZE is not defined in include/config.h! This is not good! This commit renames each of these to an existing option defined in include/config.h, or undefs the relevant option in include/config.h. BUG=b:131749055 BRANCH=none TEST=make buildall -j TEST=script above reports no options which weren't defined TEST=arcada_ish, (specifically power management, which was greatly affected by this commit) functions as normal Change-Id: Idfbd1105880174b5e160c47c4ec1d88c352d6bc6 Signed-off-by: Jack Rosenthal <jrosenth@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1592420 Reviewed-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1598526 Commit-Queue: Jett Rink <jettrink@chromium.org> Tested-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'common/version.c')
0 files changed, 0 insertions, 0 deletions