host_command: Change host command return value to enum ec_status

If the host command handler callback function returns an int, it's easy
to accidentally mix up the enum ec_error_list and enum ec_status types.
The host commands always expect an enum ec_status type, so we change the
return value to be of that explicit type. Compilation will then fail if
you accidentally try to return an enum ec_error_list value.

Ran the following commands and then manually fixed up a few remaining
instances that were not caught:

git grep --name-only 'static int .*(struct host_cmd_handler_args \*args)' |\
xargs sed -i 's#static int \(.*\)(struct host_cmd_handler_args \*args)#\
static enum ec_status \1(struct host_cmd_handler_args \*args)##'

git grep --name-only 'int .*(struct host_cmd_handler_args \*args)' |\
xargs sed -i 's#int \(.*\)(struct host_cmd_handler_args \*args)#\
enum ec_status \1(struct host_cmd_handler_args \*args)##'

BRANCH=none
BUG=chromium:1004831
TEST=make buildall -j

Cq-Depend: chrome-internal:1872675
Change-Id: Id93df9387ac53d016a1594dba86c6642babbfd1e
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1816865
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>

1 files changed, 3 insertions, 3 deletions

diff --git a/common/vstore.c b/common/vstore.c
index a2d81ba9a5..9b4636397c 100644
--- a/common/vstore.c
+++ b/common/vstore.c
@@ -38,7 +38,7 @@ BUILD_ASSERT(ARRAY_SIZE(vstore_slots) <= EC_VSTORE_SLOT_MAX);
 /*
  * vstore_info - Get slot count and mask of locked slots.
  */
-static int vstore_info(struct host_cmd_handler_args *args)
+static enum ec_status vstore_info(struct host_cmd_handler_args *args)
 {
 	struct ec_response_vstore_info *r = args->response;
 	int i;
@@ -60,7 +60,7 @@ DECLARE_HOST_COMMAND(EC_CMD_VSTORE_INFO, vstore_info, EC_VER_MASK(0));
  *
  * Response is EC_VSTORE_SLOT_SIZE bytes of data.
  */
-static int vstore_read(struct host_cmd_handler_args *args)
+static enum ec_status vstore_read(struct host_cmd_handler_args *args)
 {
 	const struct ec_params_vstore_read *p = args->params;
 	struct ec_response_vstore_read *r = args->response;
@@ -79,7 +79,7 @@ DECLARE_HOST_COMMAND(EC_CMD_VSTORE_READ, vstore_read, EC_VER_MASK(0));
 /*
  * vstore_write - Write temporary secure storage slot and lock it.
  */
-static int vstore_write(struct host_cmd_handler_args *args)
+static enum ec_status vstore_write(struct host_cmd_handler_args *args)
 {
 	const struct ec_params_vstore_write *p = args->params;
 	struct vstore_slot *slot;