diff options
| author | Eric Yilun Lin <yllin@chromium.org> | 2020-09-22 15:05:39 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-10-26 05:06:23 +0000 |
| commit | f06f0143b50326c158ecf5bb96d488d0cc5124ab (patch) | |
| tree | 7b6eaa98c7b4ff71ad49f8d6d3856af3097e4a3e /common | |
| parent | 75a9cc64fb8e85cf4ff870a4c2a929e9d758014a (diff) | |
| download | chrome-ec-f06f0143b50326c158ecf5bb96d488d0cc5124ab.tar.gz | |
syv682x: disable smart discharge mode
This config was enabled on CL:2051311. However,
with SDSG enabled, the i2c transactions will be blocked
until channel transition finished and this takes above
50ms. The extra 50ms stops us from disabling Vconn if we
unplug a SNK device which violates tVconnOff timer (35ms).
This CL reverts CL:2051311, and control VBUS discharge
by EC, and reduce the Vconn off time to 20ms.
BUG=b:160548079, b:148870148, b:163143427
TEST=on asurada, and volteer: tested that
1. vbus is discharged within tVbussOff(650ms) when unplug a SNK
device.
2. Vconn is off within tVconnOff(35ms) when unplug a SNK device
3. able to source/sink normally across plug/unplug SRC/SNK/DRP
devices.
4. discharge FET is disabled when a SRC device is connected.
5. Plug two adapters respectively, and see syv682x's discharge FET
are turned off for both ports.
BRANCH=none
Change-Id: I656c0a912b4196846de03adf2100dbb6dd89e899
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2423665
Tested-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org>
Diffstat (limited to 'common')
0 files changed, 0 insertions, 0 deletions