diff options
| author | Namyoon Woo <namyoon@chromium.org> | 2019-08-02 11:25:35 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-01-16 04:37:33 +0000 |
| commit | 2367420fd6f4a7db36c7cb566aa256e873fb33eb (patch) | |
| tree | a5b3a2f313d8dd93b85561dd932bf094f56cfbff /common | |
| parent | 53534ea1da670669eec5be9144ddc549b9fe6bc3 (diff) | |
| download | chrome-ec-2367420fd6f4a7db36c7cb566aa256e873fb33eb.tar.gz | |
extend INT_AP_L pulse
This patch extends INT_AP_L pulses to be at least 6.5 micro seconds.
It is a tentative solution to to meet Intel TGL/JSL requirement on
interrupt duration.
BUG=b:130515803
BRANCH=cr50
TEST=checked INT_AP_L pulse length ranges extended to 6.5 ~ 11 usec
with logic analyzer on Hatch.
Checked dmesg and coreboot log has no TPM errors.
Change-Id: Iea8d0a779fff7cbda0c8647f3c1de719c3c3d7e0
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2002958
Reviewed-by: Andrey Pronin <apronin@chromium.org>
Diffstat (limited to 'common')
| -rw-r--r-- | common/i2cs_tpm.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/common/i2cs_tpm.c b/common/i2cs_tpm.c index 4518eddbb9..cb893cf84f 100644 --- a/common/i2cs_tpm.c +++ b/common/i2cs_tpm.c @@ -208,6 +208,16 @@ static void wr_complete_handler(void *i2cs_data, size_t i2cs_data_size) * on the AP interrupt line for that. */ gpio_set_level(GPIO_INT_AP_L, 0); + + /* + * This is to meet the AP requirement of minimum 4 usec + * duration of INT_AP_L assertion. + * + * TODO(b/130515803): Ideally, this should be improved + * to support any duration requirement in future. + */ + tick_delay(2); + gpio_set_level(GPIO_INT_AP_L, 1); } |