summaryrefslogtreecommitdiff
path: root/common
diff options
context:
space:
mode:
authorNicolas Boichat <drinkcat@chromium.org>2017-12-14 13:32:43 +0800
committerchrome-bot <chrome-bot@chromium.org>2017-12-18 20:32:58 -0800
commitbbb40ce21d7a972c812621091390a994c6fce4b6 (patch)
treec4dd22d3473e7324a62bf00cf975721c432b264a /common
parent6aa967e4bbbdf28e0d9f5e537ccf4cbd76665b68 (diff)
downloadchrome-ec-bbb40ce21d7a972c812621091390a994c6fce4b6.tar.gz
consumer: Remove flush operation
Nobody is calling the flush function for consumer_ops structure, so let's remove it to save flash space, until we find a use for it. CQ-DEPEND=CL:*529221 BRANCH=none BUG=chromium:795624 TEST=make buildall -j, saves from 40 to 128 bytes on some boards. Change-Id: Iad18b30f419ccebc54a90914ec46da84b8d19601 Signed-off-by: Nicolas Boichat <drinkcat@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/826905 Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Diffstat (limited to 'common')
-rw-r--r--common/queue_policies.c1
-rw-r--r--common/usb_i2c.c5
-rw-r--r--common/usb_update.c5
3 files changed, 0 insertions, 11 deletions
diff --git a/common/queue_policies.c b/common/queue_policies.c
index 85395fec15..090c837fae 100644
--- a/common/queue_policies.c
+++ b/common/queue_policies.c
@@ -38,6 +38,5 @@ struct consumer const null_consumer = {
.queue = NULL,
.ops = &((struct consumer_ops const) {
.written = NULL,
- .flush = NULL,
}),
};
diff --git a/common/usb_i2c.c b/common/usb_i2c.c
index 5fa04e0ba1..cd67f68a7a 100644
--- a/common/usb_i2c.c
+++ b/common/usb_i2c.c
@@ -141,11 +141,6 @@ static void usb_i2c_written(struct consumer const *consumer, size_t count)
hook_call_deferred(config->deferred, 0);
}
-static void usb_i2c_flush(struct consumer const *consumer)
-{
-}
-
struct consumer_ops const usb_i2c_consumer_ops = {
.written = usb_i2c_written,
- .flush = usb_i2c_flush,
};
diff --git a/common/usb_update.c b/common/usb_update.c
index a97541dd9c..0ab7a3e2c6 100644
--- a/common/usb_update.c
+++ b/common/usb_update.c
@@ -552,14 +552,9 @@ static void update_out_handler(struct consumer const *consumer, size_t count)
rx_state_ = rx_outside_block;
}
-static void update_flush(struct consumer const *consumer)
-{
-}
-
struct consumer const update_consumer = {
.queue = &usb_to_update,
.ops = &((struct consumer_ops const) {
.written = update_out_handler,
- .flush = update_flush,
}),
};