diff options
| author | Abe Levkoy <alevkoy@chromium.org> | 2020-06-03 17:19:30 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-06-11 19:45:01 +0000 |
| commit | 0fb851a34753737727725f9a91ecae320a89f700 (patch) | |
| tree | 30c8033e73b706d11e265aca767b3c593e4fc7b0 /common | |
| parent | b9203fa3b2b032c3aa7b2e3ccfb01dce7eea8f22 (diff) | |
| download | chrome-ec-0fb851a34753737727725f9a91ecae320a89f700.tar.gz | |
pe_vdm_request_run: Refactor NAK/BUSY handling
Eliminate a redundant layer of checks.
BUG=none
TEST=make buildall
BRANCH=none
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Change-Id: Iae5da3a6bb5efddafab03d752e7079a67543cf46
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2234803
Reviewed-by: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'common')
| -rw-r--r-- | common/usbc/usb_pe_drp_sm.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/common/usbc/usb_pe_drp_sm.c b/common/usbc/usb_pe_drp_sm.c index 7c6d8a9f98..2d77ebe98b 100644 --- a/common/usbc/usb_pe_drp_sm.c +++ b/common/usbc/usb_pe_drp_sm.c @@ -4923,14 +4923,10 @@ static void pe_vdm_request_run(int port) if (PD_VDO_CMDT(payload[0]) == CMDT_RSP_ACK) { set_state_pe(port, PE_VDM_ACKED); return; - } else if (PD_VDO_CMDT(payload[0]) == CMDT_RSP_NAK || - PD_VDO_CMDT(payload[0]) == CMDT_RSP_BUSY) { - if (PD_VDO_CMDT(payload[0]) == CMDT_RSP_NAK) - PE_SET_FLAG(port, - PE_FLAGS_VDM_REQUEST_NAKED); - else - PE_SET_FLAG(port, - PE_FLAGS_VDM_REQUEST_BUSY); + } else if (PD_VDO_CMDT(payload[0]) == CMDT_RSP_NAK) { + PE_SET_FLAG(port, PE_FLAGS_VDM_REQUEST_NAKED); + } else if (PD_VDO_CMDT(payload[0]) == CMDT_RSP_BUSY) { + PE_SET_FLAG(port, PE_FLAGS_VDM_REQUEST_BUSY); } } else { if (sop == pe[port].tx_type && |