diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2020-02-14 12:36:49 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-02-18 20:19:25 +0000 |
| commit | 97caca87d749d7c1c341e3eb35dfba14a887d3d9 (patch) | |
| tree | 743a25c7f2fcc2ab6823ecb5a9e1829cc12a6744 /common | |
| parent | 91e799554fcfb75f16188186866d042e1754f52e (diff) | |
| download | chrome-ec-97caca87d749d7c1c341e3eb35dfba14a887d3d9.tar.gz | |
TCPMv2: Don't check RAM flag for VCONN
If the EC resets, reality might not match up with our SRAM saved flags.
Previously, this code was gating modifying VCONN based upon the SRAM
flag. However, it's possible that VCONN is still being sourced but our
flag indicates that it's not. A call to disable VCONN would be ignored
due to thinking that it's already off.
This commit simply attempts to modify VCONN to the value that was
requested. There's no harm in turning on VCONN if it's already on, or
turning it off when it's already off, therefore just set it
unconditionally.
BUG=b:149581333
BRANCH=None
TEST=Build and flash waddledoo, boot to S0, plug in a sink, reset the EC
while removing the sink, verify that VCONN is no longer sourced.
Change-Id: Id7ee84c077e05fdfc6fa3096cb92fedcfff3a3f3
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2057844
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'common')
| -rw-r--r-- | common/usbc/usb_tc_drp_acc_trysrc_sm.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/common/usbc/usb_tc_drp_acc_trysrc_sm.c b/common/usbc/usb_tc_drp_acc_trysrc_sm.c index 7e068bc71f..f4bf922101 100644 --- a/common/usbc/usb_tc_drp_acc_trysrc_sm.c +++ b/common/usbc/usb_tc_drp_acc_trysrc_sm.c @@ -1221,9 +1221,6 @@ DECLARE_HOOK(HOOK_BATTERY_SOC_CHANGE, pd_update_try_source, HOOK_PRIO_DEFAULT); static void set_vconn(int port, int enable) { - if (enable == TC_CHK_FLAG(port, TC_FLAGS_VCONN_ON)) - return; - if (enable) TC_SET_FLAG(port, TC_FLAGS_VCONN_ON); else |