diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2020-02-13 15:29:55 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-02-14 17:29:12 +0000 |
| commit | cf32f9f86ca2add5a457f53670c42123b429bffa (patch) | |
| tree | 021f29be1e2e58b0cdede663321391a33c8a7595 /common | |
| parent | b4ae96731536f40724f425df3c3a6506d9fef724 (diff) | |
| download | chrome-ec-cf32f9f86ca2add5a457f53670c42123b429bffa.tar.gz | |
tcpci: Don't set 1 CC to open based on polarity
This commit fixes an issue where the TCPCI driver was setting 1 CC line
to open when the polarity was known. This was causing issues where a
charger would only work in one orientation without a battery. Ideally,
this behaviour should be done a bit higher up in the stack whenever we
are sourcing VCONN.
BUG=b:149496312,chromium:149496312
BRANCH=hatch
TEST=Build and flash waddledoo, remove the battery, plug in a PD
charger, verify that the EC does not brown out.
Change-Id: Idbcb915c0bbd867cfafc1e32c0f6534b363a867b
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2055618
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Auto-Submit: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'common')
| -rw-r--r-- | common/usbc/usb_tc_drp_acc_trysrc_sm.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/common/usbc/usb_tc_drp_acc_trysrc_sm.c b/common/usbc/usb_tc_drp_acc_trysrc_sm.c index e6d379c34b..165be89450 100644 --- a/common/usbc/usb_tc_drp_acc_trysrc_sm.c +++ b/common/usbc/usb_tc_drp_acc_trysrc_sm.c @@ -1238,6 +1238,11 @@ static void set_vconn(int port, int enable) TC_CLR_FLAG(port, TC_FLAGS_VCONN_ON); /* + * TODO(chromium:951681): When we are sourcing VCONN, we should make + * sure to remove our termination on that CC line first. + */ + + /* * We always need to tell the TCPC to enable Vconn first, otherwise some * TCPCs get confused and think the CC line is in over voltage mode and * immediately disconnects. If there is a PPC, both devices will |