summaryrefslogtreecommitdiff
path: root/common
diff options
context:
space:
mode:
authorAbe Levkoy <alevkoy@chromium.org>2020-06-09 12:06:21 -0600
committerCommit Bot <commit-bot@chromium.org>2020-06-11 19:45:11 +0000
commitf3356585d82fe4b400fe070885e6c437481fc46c (patch)
tree528f56f8ee66a5b39ae88930d9ede6f5e0a10228 /common
parentddb0e17c669db437ba4042b15c70d23e62632557 (diff)
downloadchrome-ec-f3356585d82fe4b400fe070885e6c437481fc46c.tar.gz
TCPMv2 PE: Fix incorrect response to Not Supported
Mark modes discovery for an SVID as failed in response to a Not Supported response from a partner. Don't mark SVIDs discovery (which already succeeded) as failed. BUG=none TEST=make buildall BRANCH=none Change-Id: Id218a9108acf2adae8d4c932958ba9b2b299f3eb Signed-off-by: Abe Levkoy <alevkoy@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2238537 Reviewed-by: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'common')
-rw-r--r--common/usbc/usb_pe_drp_sm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/common/usbc/usb_pe_drp_sm.c b/common/usbc/usb_pe_drp_sm.c
index b34074986e..dadcfe02af 100644
--- a/common/usbc/usb_pe_drp_sm.c
+++ b/common/usbc/usb_pe_drp_sm.c
@@ -4683,7 +4683,7 @@ static void pe_init_vdm_modes_request_run(int port)
* A NAK would be more expected here, but Not Supported is still
* allowed with the same meaning.
*/
- pd_set_svids_discovery(port, sop, PD_DISC_FAIL);
+ pd_set_modes_discovery(port, requested_svid, sop, PD_DISC_FAIL);
} else {
/*
* Unexpected Message Received. Src.Ready or Snk.Ready can