diff options
| author | Andrew Bresticker <abrestic@chromium.org> | 2013-08-22 14:15:01 -0700 |
|---|---|---|
| committer | ChromeBot <chrome-bot@google.com> | 2013-08-24 09:37:47 -0700 |
| commit | 2271ee8c7c57a222fd1c95526f9d9b6189bd43d5 (patch) | |
| tree | 4fb9aa80705d6d2658ba56b098a3e104eade9fb3 /common | |
| parent | 8ee76987c8e91d379b4e580a2b895b454c31da45 (diff) | |
| download | chrome-ec-2271ee8c7c57a222fd1c95526f9d9b6189bd43d5.tar.gz | |
Don't send IN_PROGRESS response if GET_COMMS_STATUS is unsupported
If the EC responds to the AP with IN_PROGRESS, the AP will then use
GET_COMMS_STATUS to poll for completion of the previous command.
If the EC doesn't support GET_COMMS_STATUS, it will return an error,
confusing the AP.
BUG=chrome-os-partner:20978
TEST=flashrom on Pit
BRANCH=pit
Original-Change-Id: I7c911ebc047042450b1eefc992ba2250d35fa078
Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/66702
Reviewed-by: Randall Spangler <rspangler@chromium.org>
(cherry picked from commit 67efd2c100f9de6fe34d381f6145e2d795d8549f)
Change-Id: If102710d30cbc53670bb5652b473734c7d9251be
Reviewed-on: https://gerrit.chromium.org/gerrit/66827
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Tested-by: Andrew Bresticker <abrestic@chromium.org>
Commit-Queue: Andrew Bresticker <abrestic@chromium.org>
Diffstat (limited to 'common')
| -rw-r--r-- | common/flash_common.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/flash_common.c b/common/flash_common.c index 57bb09e0c9..f225aaaf53 100644 --- a/common/flash_common.c +++ b/common/flash_common.c @@ -577,7 +577,7 @@ static int flash_command_erase(struct host_cmd_handler_args *args) return EC_RES_ACCESS_DENIED; /* Indicate that we might be a while */ -#ifdef HAS_TASK_HOSTCMD +#if defined(HAS_TASK_HOSTCMD) && defined(CONFIG_HOST_COMMAND_STATUS) args->result = EC_RES_IN_PROGRESS; host_send_response(args); #endif |