diff options
| author | Randall Spangler <rspangler@chromium.org> | 2013-10-31 11:54:55 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-11-01 17:13:07 +0000 |
| commit | 760ace07a5cc4b7dc5e8f2ec59068a84562be162 (patch) | |
| tree | c229d8e33f43c002b5a36de13becf639b4e12b27 /core/cortex-m | |
| parent | fa13ac76b10847e133d654654f0a9418f87d11fb (diff) | |
| download | chrome-ec-760ace07a5cc4b7dc5e8f2ec59068a84562be162.tar.gz | |
cleanup: Improve / remove more TODO comments
Add bug references. Remove one assert that can no longer be triggered.
BUG=chrome-os-partner:18343
BRANCH=none
TEST=build all boards; pass unit tests
Change-Id: I3f4d2e4f2f3343a8d0531cb0715d151eaa4d0b50
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/175293
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Diffstat (limited to 'core/cortex-m')
| -rw-r--r-- | core/cortex-m/panic.c | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/core/cortex-m/panic.c b/core/cortex-m/panic.c index 9e82f241d0..310a9d5a53 100644 --- a/core/cortex-m/panic.c +++ b/core/cortex-m/panic.c @@ -402,14 +402,19 @@ void report_panic(void) panic_print(pdata); #ifdef CONFIG_DEBUG_EXCEPTIONS panic_show_process_stack(pdata); - /* TODO: Dump main stack contents as well if the exception happened - * in a handler's context. */ + /* + * TODO(crosbug.com/p/23760): Dump main stack contents as well if the + * exception happened in a handler's context. + */ #endif panic_reboot(); } -/* Default exception handler, which reports a panic. - * Naked call so we can extract raw LR and IPSR. */ +/** + * Default exception handler, which reports a panic. + * + * Declare this as a naked call so we can extract raw LR and IPSR values. + */ void exception_panic(void) __attribute__((naked)); void exception_panic(void) { |