diff options
| author | Vic (Chun-Ju) Yang <victoryang@chromium.org> | 2014-01-07 12:03:24 +0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-01-08 16:39:24 +0000 |
| commit | 61d2652ca4ea9667596cffd9a812c7a01eaf5fbe (patch) | |
| tree | 0ca160fe1e825510ae07d8a9109f3184857019d6 /core/host/panic.c | |
| parent | 221ec5438a97020b6fe641e10cee85ab7e696e1f (diff) | |
| download | chrome-ec-61d2652ca4ea9667596cffd9a812c7a01eaf5fbe.tar.gz | |
Dump stack trace on emulator test failure
Emulator test failures are sometimes hard to debug, especially when the
test is stuck somewhere and times out. Let's have the emulator dump
stack trace when an assertion fails or a test times out.
The produced stack trace is in this format:
#0 build/host/kb_8042/kb_8042.exe() [0x412421]
/home/victoryang/trunk/src/platform/ec/test/kb_8042.c:104
#1 build/host/kb_8042/kb_8042.exe() [0x4124a9]
/home/victoryang/trunk/src/platform/ec/test/kb_8042.c:129
#2 build/host/kb_8042/kb_8042.exe(run_test+0x3a) [0x412e2c]
/home/victoryang/trunk/src/platform/ec/test/kb_8042.c:262
#3 build/host/kb_8042/kb_8042.exe(_run_test+0x11) [0x4061de]
/home/victoryang/trunk/src/platform/ec/core/host/task.c:90
#4 build/host/kb_8042/kb_8042.exe(_task_start_impl+0x79) [0x406b72]
/home/victoryang/trunk/src/platform/ec/core/host/task.c:408
#5 /lib64/libpthread.so.0(+0x70b1) [0x7f6dc2fa10b1]
??:0
#6 /lib64/libc.so.6(clone+0x6d) [0x7f6dc2cd8efd]
??:0
The file name and line number in the trace is generated by addr2line.
BUG=chrome-os-partner:19235 chromium:331548
TEST=Put in a infinite loop in a test, and see stack trace when it times
out.
TEST=Add a failing assertion, and see stack trace when it fails.
BRANCH=None
Change-Id: I4494ffd1ebc98081ce40e860a146202084aa2a1e
Signed-off-by: Vic (Chun-Ju) Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/181730
Diffstat (limited to 'core/host/panic.c')
| -rw-r--r-- | core/host/panic.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/core/host/panic.c b/core/host/panic.c index 468d024552..260329cc39 100644 --- a/core/host/panic.c +++ b/core/host/panic.c @@ -8,6 +8,7 @@ #include "common.h" #include "panic.h" +#include "test_util.h" #include "util.h" void panic_assert_fail(const char *msg, const char *func, const char *fname, @@ -15,7 +16,7 @@ void panic_assert_fail(const char *msg, const char *func, const char *fname, { fprintf(stderr, "ASSERTION FAIL: %s:%d:%s - %s\n", fname, linenum, func, msg); - fflush(stderr); + task_dump_trace(); puts("Fail!"); /* Inform test runner */ fflush(stdout); |