diff options
| author | Evan Green <evgreen@chromium.org> | 2019-10-01 14:07:03 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-10-05 00:47:58 +0000 |
| commit | e77ccb89c1b74a9ba3be47072d35e3e148d2a469 (patch) | |
| tree | d229a873d4e2cb6916c55d955b1e9a971052aa2b /core | |
| parent | 1519095feaa933996ee413c87fd67de39d16213b (diff) | |
| download | chrome-ec-e77ccb89c1b74a9ba3be47072d35e3e148d2a469.tar.gz | |
Remove uses of %l
This change removes uses of %l from the EC side of the EC codebase.
This is done because the semantics of %l within printf have changed,
and there are concerns that new calls to printf will be cherry-picked
into old firmware branches without the printf changes. So, in
preparation for disallowing %l in master, remove occurrences of %l.
This change was done by manually fixing up anything found under the EC
directory with the following regex: %[0-9*.-]*l[^l]
Remember that anything on the host machine is fine as-is, since the host
printf never changed.
BUG=chromium:984041
TEST=make -j buildall
BRANCH=None
Change-Id: I2a97433ddab5bfb8a6031ca4ff1d3905289444e2
Signed-off-by: Evan Green <evgreen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1834603
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Diffstat (limited to 'core')
| -rw-r--r-- | core/minute-ia/task.c | 3 | ||||
| -rw-r--r-- | core/riscv-rv32i/task.c | 8 |
2 files changed, 4 insertions, 7 deletions
diff --git a/core/minute-ia/task.c b/core/minute-ia/task.c index 8435c2f637..75cd09a513 100644 --- a/core/minute-ia/task.c +++ b/core/minute-ia/task.c @@ -252,9 +252,6 @@ uint32_t switch_handler(int desched, task_id_t resched) if (next == current) return 0; - if (IS_ENABLED(ISH_DEBUG)) - CPRINTF("[%ld -> %ld]\n", current - tasks, next - tasks); - /* Switch to new task */ if (IS_ENABLED(CONFIG_TASK_PROFILING)) task_switches++; diff --git a/core/riscv-rv32i/task.c b/core/riscv-rv32i/task.c index 477bba3f2e..453b7a76f1 100644 --- a/core/riscv-rv32i/task.c +++ b/core/riscv-rv32i/task.c @@ -614,7 +614,7 @@ void task_print_list(void) sp++) stackused -= sizeof(uint32_t); - ccprintf("%4d %c %-16s %08x %11.6ld %3d/%3d\n", i, is_ready, + ccprintf("%4d %c %-16s %08x %11.6lld %3d/%3d\n", i, is_ready, task_names[i], tasks[i].events, tasks[i].runtime, stackused, tasks_init[i].stack_size); cflush(); @@ -643,10 +643,10 @@ int command_task_info(int argc, char **argv) ccprintf("Service calls: %11d\n", svc_calls); ccprintf("Total exceptions: %11d\n", total + svc_calls); ccprintf("Task switches: %11d\n", task_switches); - ccprintf("Task switching started: %11.6ld s\n", task_start_time); - ccprintf("Time in tasks: %11.6ld s\n", + ccprintf("Task switching started: %11.6lld s\n", task_start_time); + ccprintf("Time in tasks: %11.6lld s\n", get_time().val - task_start_time); - ccprintf("Time in exceptions: %11.6ld s\n", exc_total_time); + ccprintf("Time in exceptions: %11.6lld s\n", exc_total_time); #endif return EC_SUCCESS; |