diff options
author | Bill Richardson <wfrichar@chromium.org> | 2016-08-22 17:55:12 -0700 |
---|---|---|
committer | Bill Richardson <wfrichar@chromium.org> | 2016-08-24 16:30:10 +0000 |
commit | bb15561db56728b83ee7fe35e534da7577a7729d (patch) | |
tree | e586ee3b18c8fda464da38b42a06845f0d7f6786 /core | |
parent | f322e32a3ec052be3f0c226145448fed63aa7ef9 (diff) | |
download | chrome-ec-bb15561db56728b83ee7fe35e534da7577a7729d.tar.gz |
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
Since pretty much always, we've declared console commands to take
a "longhelp" argument with detailed explanations of what the
command does. But since almost as long, we've never actually used
that argument for anything - we just silently throw it away in
the macro. There's only one command (usbchargemode) that even
thinks it defines that argument.
We're never going to use this, let's just get rid of it.
BUG=none
BRANCH=none
CQ-DEPEND=CL:*279060
CQ-DEPEND=CL:*279158
CQ-DEPEND=CL:*279037
TEST=make buildall; tested on Cr50 hardware
Everything builds. Since we never used this arg anyway, there had
better not be any difference in the result.
Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374163
Reviewed-by: Myles Watson <mylesgw@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'core')
-rw-r--r-- | core/cortex-m/task.c | 6 | ||||
-rw-r--r-- | core/cortex-m0/task.c | 6 | ||||
-rw-r--r-- | core/minute-ia/task.c | 8 | ||||
-rw-r--r-- | core/nds32/task.c | 6 |
4 files changed, 9 insertions, 17 deletions
diff --git a/core/cortex-m/task.c b/core/cortex-m/task.c index ae2882ac10..7b80c1584a 100644 --- a/core/cortex-m/task.c +++ b/core/cortex-m/task.c @@ -608,8 +608,7 @@ int command_task_info(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(taskinfo, command_task_info, NULL, - "Print task info", - NULL); + "Print task info"); #ifdef CONFIG_CMD_TASKREADY static int command_task_ready(int argc, char **argv) @@ -626,8 +625,7 @@ static int command_task_ready(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(taskready, command_task_ready, "[setmask]", - "Print/set ready tasks", - NULL); + "Print/set ready tasks"); #endif void task_pre_init(void) diff --git a/core/cortex-m0/task.c b/core/cortex-m0/task.c index 5d219a5149..b5f9aef40c 100644 --- a/core/cortex-m0/task.c +++ b/core/cortex-m0/task.c @@ -599,8 +599,7 @@ int command_task_info(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(taskinfo, command_task_info, NULL, - "Print task info", - NULL); + "Print task info"); #ifdef CONFIG_CMD_TASKREADY static int command_task_ready(int argc, char **argv) @@ -617,8 +616,7 @@ static int command_task_ready(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(taskready, command_task_ready, "[setmask]", - "Print/set ready tasks", - NULL); + "Print/set ready tasks"); #endif void task_pre_init(void) diff --git a/core/minute-ia/task.c b/core/minute-ia/task.c index 033cd1e5c0..fec005e0a0 100644 --- a/core/minute-ia/task.c +++ b/core/minute-ia/task.c @@ -1,4 +1,4 @@ -/* Copyright (c) 2016 The Chromium OS Authors. All rights reserved. +/* Copyright 2016 The Chromium OS Authors. All rights reserved. * Use of this source code is governed by a BSD-style license that can be * found in the LICENSE file. */ @@ -574,8 +574,7 @@ int command_task_info(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(taskinfo, command_task_info, NULL, - "Print task info", - NULL); + "Print task info"); #ifdef CONFIG_CMD_TASKREADY static int command_task_ready(int argc, char **argv) @@ -592,8 +591,7 @@ static int command_task_ready(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(taskready, command_task_ready, "[setmask]", - "Print/set ready tasks", - NULL); + "Print/set ready tasks"); #endif void task_pre_init(void) diff --git a/core/nds32/task.c b/core/nds32/task.c index f983962cff..dc83cba088 100644 --- a/core/nds32/task.c +++ b/core/nds32/task.c @@ -706,8 +706,7 @@ int command_task_info(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(taskinfo, command_task_info, NULL, - "Print task info", - NULL); + "Print task info"); static int command_task_ready(int argc, char **argv) { @@ -723,8 +722,7 @@ static int command_task_ready(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(taskready, command_task_ready, "[setmask]", - "Print/set ready tasks", - NULL); + "Print/set ready tasks"); void task_pre_init(void) { |