diff options
| author | Vincent Palatin <vpalatin@chromium.org> | 2012-06-25 21:09:52 +0000 |
|---|---|---|
| committer | Gerrit <chrome-bot@google.com> | 2012-06-25 17:52:47 -0700 |
| commit | b8d7d8fc44b6e1b4e1fef268e6a6a68dbc6f845e (patch) | |
| tree | a51ab4776cf33f8abcb46265cbf37c13eb21dd2e /core | |
| parent | 900c0215b4f47551c850259ef7c716285c46e8b5 (diff) | |
| download | chrome-ec-b8d7d8fc44b6e1b4e1fef268e6a6a68dbc6f845e.tar.gz | |
fix panic serial code
panic_putc was doing an infinite loop on platforms with a UART FIFO.
(e.g. LM4F)
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
BUG=chrome-os-partner:10825
TEST=on Link EVT and Lucas DVT, type "rw 1" in the EC serial console and
see the panic trace.
Change-Id: I47f43183e6e938b88874c80244430ddf88c5a567
Reviewed-on: https://gerrit.chromium.org/gerrit/26052
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Tested-by: Vincent Palatin <vpalatin@chromium.org>
Commit-Ready: Vincent Palatin <vpalatin@chromium.org>
Diffstat (limited to 'core')
| -rw-r--r-- | core/cortex-m/panic.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/core/cortex-m/panic.c b/core/cortex-m/panic.c index 3099887dcb..1663d8fd93 100644 --- a/core/cortex-m/panic.c +++ b/core/cortex-m/panic.c @@ -35,8 +35,7 @@ void panic_putc(int ch) if (ch == '\n') panic_putc('\r'); uart_write_char(ch); - while (uart_tx_ready()) - ; + uart_tx_flush(); } |