diff options
author | Daisuke Nojiri <dnojiri@chromium.org> | 2019-04-03 11:03:23 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2019-04-08 22:30:32 -0700 |
commit | 6bd030ecd978a8b619da261510490f27f68c4e6c (patch) | |
tree | 4cd5827d1842384d477eb7f9d68c05ec7906c2ec /cts | |
parent | b4cca02d9dcc5c7fa42813ae819933fd5ae9f43c (diff) | |
download | chrome-ec-6bd030ecd978a8b619da261510490f27f68c4e6c.tar.gz |
ec.tasklist: Consolidate duplicate comments
It's simply a bad idea to describe a macro in multiple locations.
It'll make it hard to change. It'll be difficult to keep all
locations in sync.
This patch replaces the comment duplicated in all ec.tasklist with
a pointer to the CONFIG_TASK_LIST definition. The macro will be
described in a single place (just like all/most other macros).
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
BUG=none
BRANCH=none
TEST=buildall
Change-Id: Id658b9d68e742e4334c692b804d9c98c8de21313
Reviewed-on: https://chromium-review.googlesource.com/1551579
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'cts')
-rw-r--r-- | cts/cts.tasklist | 12 | ||||
-rw-r--r-- | cts/mutex/cts.tasklist | 10 | ||||
-rw-r--r-- | cts/task/cts.tasklist | 10 |
3 files changed, 3 insertions, 29 deletions
diff --git a/cts/cts.tasklist b/cts/cts.tasklist index 73e959684f..152b0d02b2 100644 --- a/cts/cts.tasklist +++ b/cts/cts.tasklist @@ -4,17 +4,7 @@ */ /** - * List of enabled tasks in the priority order - * - * The first one has the lowest priority. - * - * For each task, use the macro TASK_ALWAYS(n, r, d, s) for base tasks and - * TASK_NOTEST(n, r, d, s) for tasks that can be excluded in test binaries, - * where : - * 'n' in the name of the task - * 'r' in the main routine of the task - * 'd' in an opaque parameter passed to the routine at startup - * 's' is the stack size in bytes; must be a multiple of 8 + * See CONFIG_TASK_LIST in config.h for details. */ /* Default task list for suites which don't define its own */ diff --git a/cts/mutex/cts.tasklist b/cts/mutex/cts.tasklist index 32cfb865b9..3387e1de09 100644 --- a/cts/mutex/cts.tasklist +++ b/cts/mutex/cts.tasklist @@ -4,15 +4,7 @@ */ /** - * List of enabled tasks in the priority order - * - * The first one has the lowest priority. - * - * For each task, use the macro TASK_ALWAYS(n, r, d, s) where : - * 'n' in the name of the task - * 'r' in the main routine of the task - * 'd' in an opaque parameter passed to the routine at startup - * 's' is the stack size in bytes; must be a multiple of 8 + * See CONFIG_TASK_LIST in config.h for details. */ #define CONFIG_CTS_TASK_LIST \ TASK_ALWAYS(MTX3C, mutex_random_task, NULL, 384) \ diff --git a/cts/task/cts.tasklist b/cts/task/cts.tasklist index 8c181b3e5c..b87fd7a3df 100644 --- a/cts/task/cts.tasklist +++ b/cts/task/cts.tasklist @@ -4,15 +4,7 @@ */ /** - * List of enabled tasks in the priority order - * - * The first one has the lowest priority. - * - * For each task, use the macro TASK_ALWAYS(n, r, d, s) where : - * 'n' in the name of the task - * 'r' in the main routine of the task - * 'd' in an opaque parameter passed to the routine at startup - * 's' is the stack size in bytes; must be a multiple of 8 + * See CONFIG_TASK_LIST in config.h for details. */ #define CONFIG_CTS_TASK_LIST \ TASK_ALWAYS(A, task_abc, NULL, TASK_STACK_SIZE) \ |