diff options
| author | Jeremy Bettis <jbettis@google.com> | 2023-03-24 10:10:50 -0600 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2023-03-24 21:58:28 +0000 |
| commit | 2f43481a9e5cd627496121fd4c2f7d6d95989618 (patch) | |
| tree | 9ff3d248ea848272d3521949a0ab95eb50539f4d /docs | |
| parent | 38f07aec87e712f99393ebcfc362e56501027be0 (diff) | |
| download | chrome-ec-2f43481a9e5cd627496121fd4c2f7d6d95989618.tar.gz | |
ec: Update pupr instructions
You should abandon cls that are bad, don't downvote them.
BRANCH=None
BUG=b:274462658
TEST=Abandoned a cl
Change-Id: Ic9ee9d927155cd4ddb766527f643f81dd9d6f3d9
Signed-off-by: Jeremy Bettis <jbettis@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4368547
Commit-Queue: Jeremy Bettis <jbettis@chromium.org>
Reviewed-by: George Engelbrecht <engeg@google.com>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
Auto-Submit: Jeremy Bettis <jbettis@chromium.org>
Tested-by: Jeremy Bettis <jbettis@chromium.org>
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/pupr.md | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/docs/pupr.md b/docs/pupr.md index bb7d110bae..cf97f4e381 100644 --- a/docs/pupr.md +++ b/docs/pupr.md @@ -13,6 +13,11 @@ For the most part you can ignore these CLs. You don't need to add CR+2 nor CQ+2. However if you see that the CL has failed the CQ several times, you should check and see if there is a real bug that is preventing the CL from submitting. +If there is a pupr cl that is known bad, i.e. there is a breakage in the code +and pupr needs to pick a different cl, then please Abandon that cl, don't +CR-2 it. Pupr will keep adding CQ+2 to the cl over and over again until it +submits, even if it never will. + ## Failure implications If the CL fails to merge, then the ectool binary will not be built with the |