diff options
| author | Jett Rink <jettrink@chromium.org> | 2020-03-10 07:47:02 -0600 |
|---|---|---|
| committer | Jett Rink <jettrink@chromium.org> | 2020-03-10 13:49:03 +0000 |
| commit | 0725b311c0009320aa3404f2b77e54e2eabe8351 (patch) | |
| tree | d699fa799395a03ea42200b609a03e5b6f73bd08 /docs | |
| parent | e990ff2bf973638d38dc8c0c36457b2f310345a4 (diff) | |
| download | chrome-ec-0725b311c0009320aa3404f2b77e54e2eabe8351.tar.gz | |
code_review: add 's' to --no-email option
According to `repo help upload`, the option should be --no-emails
instead of --no-email.
BRANCH=none
BUG=none
TEST=`repo upload --no-emails` works
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: I72b6d2b01e75864ea3223763fd2c8d463f2b5919
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2095948
Diffstat (limited to 'docs')
| -rw-r--r-- | docs/code_reviews.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/docs/code_reviews.md b/docs/code_reviews.md index 19c831e410..c3fe407aca 100644 --- a/docs/code_reviews.md +++ b/docs/code_reviews.md @@ -58,7 +58,7 @@ Add your name to the [list of reviewers][1]. * Associate a bug with a code review (`BUG=...`) when context is relevant. * Indicate clearly when a CL is not yet ready for review and when it is; don’t start the review until you’ve stopped making changes. - * Use `repo upload --no-email` to avoid sending emails for CLs not ready for + * Use `repo upload --no-emails` to avoid sending emails for CLs not ready for review. * Use Gerrit comments as needed to clarify that a CL is now ready for review. * Recommended: Leave “WIP” in the CL title until it is ready to review. @@ -94,7 +94,7 @@ Add your name to the [list of reviewers][1]. wait for that patchset. * If practical, don’t upload a new patchset until you can usefully respond to all unresolved comments. - * Use `repo upload --no-email` for patchsets that address comments before the + * Use `repo upload --no-emails` for patchsets that address comments before the responses to those comments. * Try to minimize rebases in the middle of a review; if practical, don’t rebase until just before submitting. |