summaryrefslogtreecommitdiff
path: root/driver/accelgyro_bmi160.c
diff options
context:
space:
mode:
authorYilun Lin <yllin@google.com>2018-09-08 00:06:09 +0800
committerchrome-bot <chrome-bot@chromium.org>2018-09-13 06:13:47 -0700
commitc4a842a78c778e7c15cd3f78ae354e4d21a85ae9 (patch)
tree6668b4fd3911769f0011b5b17512d66923eea5fc /driver/accelgyro_bmi160.c
parente6344f8560bad936573be75f6b2810373c2cdb01 (diff)
downloadchrome-ec-c4a842a78c778e7c15cd3f78ae354e4d21a85ae9.tar.gz
type: Rename vector_3_t to intv3_t.
Naming of many vector types and matrix types are not clear enough. For example, we have: vector_3_t, which is a vector of three int. vec3_t, which is a vector of three float. size4_t, which is a vector of four size_t. mat33_t, which is a 3x3 matrix of float. matrix_3x3_t, which is a 3x3 matrix of fixed point. Besides, we have types like int8_t, uint16_t types. To clearly distinguished types, the CL propose to, For vector types, naming should be `$type + 'v' + $num + '_t'`: vector_3_t becomes intv3_t vec3_t becomes floatv3_t vector 4 of uint16_t becomes uint16v4_t (which doesn't exist yet) For matrix types, naming should be `mat$N$N_` + $type + '_t', where $N is the matrix size: matrix_3x3_t becomes mat33_fp_t # fp: fixed point mat33_t becomes mat33_float_t TEST=make buildall -j BUG=b:114662791 Change-Id: I865aa3ecbab6cb97f8585a081a679adf00febe1d Signed-off-by: Yilun Lin <yllin@google.com> Reviewed-on: https://chromium-review.googlesource.com/1215442 Commit-Ready: Yilun Lin <yllin@chromium.org> Tested-by: Yilun Lin <yllin@chromium.org> Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'driver/accelgyro_bmi160.c')
-rw-r--r--driver/accelgyro_bmi160.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/driver/accelgyro_bmi160.c b/driver/accelgyro_bmi160.c
index 084304af54..8966d57261 100644
--- a/driver/accelgyro_bmi160.c
+++ b/driver/accelgyro_bmi160.c
@@ -475,7 +475,7 @@ static int get_offset(const struct motion_sensor_t *s,
int16_t *temp)
{
int i, val, val98;
- vector_3_t v;
+ intv3_t v;
switch (s->type) {
case MOTIONSENSE_TYPE_ACCEL:
@@ -535,7 +535,7 @@ static int set_offset(const struct motion_sensor_t *s,
int16_t temp)
{
int ret, i, val, val98;
- vector_3_t v = { offset[X], offset[Y], offset[Z] };
+ intv3_t v = { offset[X], offset[Y], offset[Z] };
rotate_inv(v, *s->rot_standard_ref, v);
@@ -647,7 +647,7 @@ end_perform_calib:
return ret;
}
-void normalize(const struct motion_sensor_t *s, vector_3_t v, uint8_t *data)
+void normalize(const struct motion_sensor_t *s, intv3_t v, uint8_t *data)
{
#ifdef CONFIG_MAG_BMI160_BMM150
if (s->type == MOTIONSENSE_TYPE_MAG)
@@ -1120,7 +1120,7 @@ static int irq_handler(struct motion_sensor_t *s, uint32_t *event)
#endif /* CONFIG_ACCEL_INTERRUPTS */
-static int read(const struct motion_sensor_t *s, vector_3_t v)
+static int read(const struct motion_sensor_t *s, intv3_t v)
{
uint8_t data[6];
int ret, status = 0;