diff options
| author | Bhanu Prakash Maiya <bhanumaiya@google.com> | 2021-07-14 10:58:47 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-07-15 19:57:33 +0000 |
| commit | e14e67127a9cb710c4415b3248d8cef7b8f4c8c4 (patch) | |
| tree | 70344e070b33caf6f2fb214bb8b65a650ecadad0 /driver/accelgyro_bmi3xx.c | |
| parent | 79f69442e4325233804994729cdad5db7fa0a09d (diff) | |
| download | chrome-ec-e14e67127a9cb710c4415b3248d8cef7b8f4c8c4.tar.gz | |
driver: bmi3xx: Remove latch settings from interrupt ctrl reg
Latch configuration force interrupt to stay in high state which
results in prolonged interrupts. This is not needed on ChromeOS EC
BRANCH=none
BUG=b:178398789
TEST=Accel implementation tested on Guybrush
EC commands:
> accelinfo
> acceldata
Signed-off-by: Bhanu Prakash Maiya <bhanumaiya@chromium.org>
Signed-off-by: Latchiamaran Senram <latchiamaran.senram@bosch.corp-partner.google.com>
Change-Id: I50e28cbd252345a3d6fac2b449680197d7419212
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3027680
Tested-by: Bhanu Prakash Maiya <bhanumaiya@google.com>
Auto-Submit: Bhanu Prakash Maiya <bhanumaiya@google.com>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org>
Commit-Queue: Bhanu Prakash Maiya <bhanumaiya@google.com>
Diffstat (limited to 'driver/accelgyro_bmi3xx.c')
| -rw-r--r-- | driver/accelgyro_bmi3xx.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/driver/accelgyro_bmi3xx.c b/driver/accelgyro_bmi3xx.c index 14bbfe7b26..a887093530 100644 --- a/driver/accelgyro_bmi3xx.c +++ b/driver/accelgyro_bmi3xx.c @@ -168,7 +168,7 @@ static int config_interrupt(const struct motion_sensor_t *s) goto err_unlock; /* Get the previous configuration data */ - ret = bmi3_read_n(s, BMI3_REG_IO_INT_CTRL, reg_data, 6); + ret = bmi3_read_n(s, BMI3_REG_IO_INT_CTRL, reg_data, 4); if (ret) goto err_unlock; @@ -181,14 +181,10 @@ static int config_interrupt(const struct motion_sensor_t *s) reg_data[2] = BMI3_SET_BITS(reg_data[2], BMI3_INT1_OUTPUT_EN, BMI3_INT_OUTPUT_ENABLE); - reg_data[4] = BMI3_SET_BIT_POS0(reg_data[4], BMI3_INT_LATCH, - BMI3_INT_LATCH_EN); - /* - * Set the interrupt pin configurations and - * latch settings + * Set the interrupt pin configurations */ - ret = bmi3_write_n(s, BMI3_REG_IO_INT_CTRL, ®_data[2], 4); + ret = bmi3_write_n(s, BMI3_REG_IO_INT_CTRL, ®_data[2], 2); if (ret) goto err_unlock; |