summaryrefslogtreecommitdiff
path: root/driver/battery
diff options
context:
space:
mode:
authorYilun Lin <yllin@chromium.org>2019-08-22 16:52:20 +0800
committerCommit Bot <commit-bot@chromium.org>2019-08-23 02:59:28 +0000
commita63ae25e23ac05e96812facb5211e68b1245b653 (patch)
tree3bbbb090e82558f1605350c11e33a10e1ad7c917 /driver/battery
parenta2e7b77b3b62d9f663eb1f916fe9ab36bef06dbe (diff)
downloadchrome-ec-a63ae25e23ac05e96812facb5211e68b1245b653.tar.gz
battery/mm8013: fix battery present status
Tighter battery present status by returning BP_NO. charger task will try to charge battery when battery present status is BP_NOT_SURE, and this would put PD and charger tasks in a weird state (and keep resetting) if the battery is actually not present. TEST=boot krane w/o battery and w/ PD charger, and see it doesn't reset for over 5 mins. BUG=b:139509751 BRANCH=none Change-Id: I3e3d818b80ffcfdb12fbd83daafa792d837a0fe0 Signed-off-by: Yilun Lin <yllin@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1765108 Reviewed-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'driver/battery')
-rw-r--r--driver/battery/mm8013.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/driver/battery/mm8013.c b/driver/battery/mm8013.c
index d7fba89076..6013146be9 100644
--- a/driver/battery/mm8013.c
+++ b/driver/battery/mm8013.c
@@ -170,7 +170,7 @@ enum battery_present battery_is_present(void)
int temp;
if (mm8013_read16(REG_TEMPERATURE, &temp))
- return BP_NOT_SURE;
+ return BP_NO;
return BP_YES;
}